streaming fetch progress reporting odd
Bug #374740 reported by
Robert Collins
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Parth Malwankar |
Bug Description
We may need protocol tweaks, but we should minimally have something reasonably that shows progress not total activity.
Related branches
lp:~parthm/bzr/538868-message-for-heavy-checkout
- Vincent Ladeuil: Approve
- Gary van der Merwe: Abstain
- John A Meinel: Needs Fixing
- bzr-core: Pending (2nd review) requested
- Martin Pool: Pending (2nd review) requested
-
Diff: 357 lines (+160/-23)8 files modifiedNEWS (+3/-3)
bzrlib/builtins.py (+0/-5)
bzrlib/recordcounter.py (+86/-0)
bzrlib/remote.py (+2/-1)
bzrlib/repofmt/groupcompress_repo.py (+23/-4)
bzrlib/repository.py (+6/-4)
bzrlib/smart/repository.py (+40/-4)
bzrlib/tests/blackbox/test_checkout.py (+0/-2)
Changed in bzr: | |
status: | Triaged → Confirmed |
Changed in bzr: | |
status: | Confirmed → In Progress |
assignee: | nobody → Parth Malwankar (parthm) |
Changed in bzr: | |
milestone: | none → 2.2b3 |
Changed in bzr: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
Just as a comment, the new code path grabs a StreamSource and a StreamSink, and then passes the stream from source into sink. The code handling this is bzrlib. fetch.RepoFetch er. Both Source and Sink could be local, or could be remote, only the RepoFetcher is known to be the local client. It never sees individual records, but perhaps it could get callbacks somehow, so that it can update progress info.