Lyrics downloader doesn't fully convert artist and title
Bug #374326 reported by
Matt Layman
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Entertainer Media Center |
Fix Released
|
Low
|
Matt Layman | ||
Bug Description
Currently, there is a TODO in the source of lyrics_downloader
# TODO: Find out what the special symbols are (', &, ...)
I'm replacing this in a branch that removes TODO lines by adding an XXX. With that, I'm also generating this bug report because this is an incomplete implementation that needs to be cleaned up. It seems like the code doesn't fully convert the artist and title for a url. This may produce subpar results in the searching process. Here is the full comment in the code:
# Convert title and artist to use in url, special symbols have to be
# replaced by a '%' not '%xx'
# XXX: laymansterms - Find out what the special symbols are (', &, ...)
# not letters, digits, spaces and ()$^*=:
Related branches
lp:~mblayman/entertainer/bye-feedz
- Matt Layman: Approve
-
Diff: 6235 lines (+421/-4001)53 files modifiedMakefile (+0/-22)
cfg/content.conf (+0/-4)
docs/DEPENDENCIES (+2/-1)
entertainer (+0/-1)
entertainerlib/backend/backend_server.py (+6/-36)
entertainerlib/backend/components/feeds/__init__.py (+0/-2)
entertainerlib/backend/components/feeds/feed_fetcher.py (+0/-138)
entertainerlib/backend/components/feeds/feed_manager.py (+0/-100)
entertainerlib/backend/components/feeds/feed_utils.py (+0/-239)
entertainerlib/backend/core/message_type_priority.py (+3/-12)
entertainerlib/client/backend_connection.py (+0/-27)
entertainerlib/client/client.py (+4/-11)
entertainerlib/client/medialibrary/feeds.py (+0/-192)
entertainerlib/client/medialibrary/music.py (+2/-0)
entertainerlib/client/medialibrary/videos.py (+2/-1)
entertainerlib/client/translation_setup.py (+2/-3)
entertainerlib/configuration.py (+0/-12)
entertainerlib/db/models.py (+1/-53)
entertainerlib/dialog.py (+0/-298)
entertainerlib/download.py (+3/-3)
entertainerlib/gui/screens/factory.py (+2/-25)
entertainerlib/gui/screens/feed.py (+0/-102)
entertainerlib/gui/screens/feed_entry.py (+0/-112)
entertainerlib/gui/screens/main.py (+3/-101)
entertainerlib/gui/screens/rss.py (+0/-228)
entertainerlib/gui/user_interface.py (+6/-6)
entertainerlib/indexing/handlers.py (+28/-28)
entertainerlib/indexing/indexer.py (+3/-0)
entertainerlib/network/local/client.py (+7/-7)
entertainerlib/tests/data/FeedConfigTools/test.opml (+0/-19)
entertainerlib/tests/data/OPMLParser/lifereaMultiple/.liferea_1.4/feedlist.opml (+0/-1)
entertainerlib/tests/data/OPMLParser/lifereaSingle/.liferea/feedlist.opml (+0/-1)
entertainerlib/tests/data/OPMLParser/noXML.txt (+0/-1)
entertainerlib/tests/data/OPMLParser/opmlInOpml.opml (+0/-21)
entertainerlib/tests/data/OPMLParser/test.opml (+0/-20)
entertainerlib/tests/mock.py (+1/-77)
entertainerlib/tests/test_configuration.py (+0/-6)
entertainerlib/tests/test_feedconfigtools.py (+0/-69)
entertainerlib/tests/test_feedentryparser.py (+0/-49)
entertainerlib/tests/test_filehandlers.py (+1/-0)
entertainerlib/tests/test_frontendfeed.py (+0/-95)
entertainerlib/tests/test_frontendfeedentry.py (+0/-92)
entertainerlib/tests/test_frontendfeedlibrary.py (+0/-107)
entertainerlib/tests/test_models.py (+0/-45)
entertainerlib/tests/test_music.py (+8/-6)
entertainerlib/tests/test_opmlparser.py (+0/-103)
entertainerlib/tests/test_screenfactory.py (+6/-30)
entertainerlib/tests/test_userinterface.py (+1/-3)
entertainerlib/tests/test_videometadatasearch.py (+0/-1)
entertainerlib/uis/manager.ui (+330/-1251)
entertainerlib/uis/open_feed_source_dialog.ui (+0/-198)
themes/Black/theme.conf (+0/-19)
tools/loc.py (+0/-23)
| Changed in entertainer: | |
| assignee: | nobody → Matt Layman (laymansterms) |
| importance: | Undecided → Low |
| milestone: | none → entertainer-0.5 |
| status: | New → In Progress |
| Changed in entertainer: | |
| status: | In Progress → Fix Committed |
| Changed in entertainer: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
