VPATH builds broken

[Robert Collins]

to reproduce:
take a new branch # [important!]
bzr branch lp:drizzle test
config/autorun.sh
mkdir ../build
cd ../build
../test/configure
make
...
"No target to make 'all'. Stop" in po

cause:
AM_PO_SUBDIRS, defined in po.m4 looks for POTFILES.in in $(srcdir), but
drizzle's configure creates it in $(builddir)

solutions:
fix AM_PO_SUBDIRS to look in both $(builddir) and $(srcdir) - best but
   will require some care to make sure system copies don't override;
   its not hard but I don't remember the exact aclocal details offhand
stop creating POTFILES.in from configure - possibly easiest, but I don't
   know why you do this anyhow.
document that VPATH builds are not supported from bzr - worst

 affects drizzle
--

[Monty Taylor (mordred)]

Robert Collins wrote:
> Public bug reported:
>
> to reproduce:
> take a new branch # [important!]
> bzr branch lp:drizzle test
> config/autorun.sh
> mkdir ../build
> cd ../build
> ../test/configure
> make
> ...
> "No target to make 'all'. Stop" in po

Very Bizarre. I'm always doing vpath builds- although your assessment
here makes sense. I wonder what I'm doing to _not_ hit his problem.

> cause:
> AM_PO_SUBDIRS, defined in po.m4 looks for POTFILES.in in $(srcdir), but
> drizzle's configure creates it in $(builddir)
>
> solutions:
> fix AM_PO_SUBDIRS to look in both $(builddir) and $(srcdir) - best but
> will require some care to make sure system copies don't override;
> its not hard but I don't remember the exact aclocal details offhand

Yeah. I'll look in to this.

> stop creating POTFILES.in from configure - possibly easiest, but I don't
> know why you do this anyhow.

We generate it because of plugins... although now that you mention, I
think perhaps I should generate it as a part of register_plugins or
something. I'll look in to that, too.

> document that VPATH builds are not supported from bzr - worst

Absolutely unacceptable choice. We'll fix it one of the other ways.

> affects drizzle
> --
>
> ** Affects: drizzle
> Importance: Undecided
> Status: New
>

[Robert Collins (lifeless)]

On Sun, 2009-05-10 at 01:58 +0000, Monty Taylor wrote:
> Robert Collins wrote:
> > Public bug reported:
> >
> > to reproduce:
> > take a new branch # [important!]
> > bzr branch lp:drizzle test
> > config/autorun.sh
> > mkdir ../build
> > cd ../build
> > ../test/configure
> > make
> > ...
> > "No target to make 'all'. Stop" in po
>
> Very Bizarre. I'm always doing vpath builds- although your assessment
> here makes sense. I wonder what I'm doing to _not_ hit his problem.

You're using a dir you've done a regular build in at some point, I
expect.

I worked around it doing
ln -s ../../build/po/POTFILES.in

-Rob

[Monty Taylor (mordred)]

This should have been fixed actually quite a while ago. We do the POTFILES.in generation in config/autorun.sh now, releated to the register_plugins.py script (plugins being the reason we were generating the file to begin with)