'authentication.conf' accepts a server name of the form 'server:port'

[Amit Saha]

According to the manual [1], the port number may be specified by using 'port', when the default port is not used. However, when the server is specified as 'server:port' there is no warning or error message.

[1]. http://doc.bazaar-vcs.org/bzr.dev/en/user-reference/bzr_man.html#authentication-settings

[Martin Pool (mbp)]

2009/5/10 Amit Saha <email address hidden>:
> Public bug reported:
>
> According to the manual [1], the port number may be specified by using
> 'port', when the default port is not used. However, when the server is
> specified as 'server:port' there is no warning or error message.

And you want an error because a specification of this type won't
actually match a URL with the port given?

--
Martin <http://launchpad.net/~mbp/>

[Vincent Ladeuil (vila)]

@Martin, yes, authentication.conf doesn't expect a ':port' in a host and will therefore ignore it.

Giving an error if it occurs will help unaware users realize the problem.

[Ashley Anderson (aganders3)]

I see Vincent has offered to mentor for this bug, and I would be willing to attempt it. I have taken a look at the code and it seems some simple conditional statements in 'config.py' would do the trick. Does this seem right?

[Vincent Ladeuil (vila)]

Yes, but tests are required, look at bzrlib/tests/test_config.py for examples.

test_ssh_password_emits_warning is a test that checks that the warning is emitted for example.