error building revision 307

[nucleo]

Linuxdcpp revision 307 builds with errors:

scons: Reading SConscript files ...
Checking for g++ >= 4.1...(cached) yes
Checking for pkg-config... (cached) yes
Checking for gtk+-2.0 >= 2.10... (cached) yes
Checking for gthread-2.0 >= 2.4... (cached) yes
Checking for libglade-2.0 >= 2.4... (cached) yes
Checking for C++ header file boost/version.hpp... (cached) yes
Checking for C header file time.h... (cached) yes
Checking for C header file signal.h... (cached) yes
Checking for C header file unistd.h... (cached) yes
Checking for C library pthread... (cached) yes
Checking for C library z... (cached) yes
Checking for C library bz2... (cached) yes
Checking for C library crypto... (cached) yes
Checking for C library ssl... (cached) yes
Checking for C header file iconv.h... (cached) yes
Checking for iconv(0, (const char **)0, 0, (char**)0, 0) in C library iconv... (cached) no
Checking for C header file net/if.h... (cached) yes
scons: done reading SConscript files.
scons: Building targets ...
g++ -o build/release/gui/transfers.o -c -I. -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_REENTRANT -fpermissive -DHAVE_IFADDRS_H -O3 -fomit-frame-pointer -DNDEBUG -D_DATADIR='"/usr/share"' -pthread -I/usr/include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/include/libxml2 -I/usr/lib/gtk-2.0/include-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 linux/transfers.cc
In file included from ./dcpp/File.h:27,
                 from ./dcpp/UserConnection.h:29,
                 from ./dcpp/ConnectionManager.h:25,
                 from linux/transfers.hh:28,
                 from linux/transfers.cc:26:
./dcpp/Streams.h: In member function 'virtual size_t dcpp::LimitedOutputStream<managed>::write(const void*, size_t)':
./dcpp/Streams.h:140: warning: there are no arguments to '_' that depend on a template parameter, so a declaration of '_' must be available
linux/transfers.cc: In member function 'void Transfers::calculateParent_gui(GtkTreeIter*)':
linux/transfers.cc:587: error: 'ostream_iterator' is not a member of 'std'
linux/transfers.cc:587: error: expected primary-expression before '>' token
scons: *** [build/release/gui/transfers.o] Error 1
scons: building terminated because of errors.

[Vitaliy Okulov (vitaliy-okulov)]

Warning steel exist:

g++ -o build/release/gui/downloadqueue.o -c -g -O2 -I. -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_REENTRANT -fpermissive -DHAVE_IFADDRS_H -O3 -fomit-frame-pointer -DNDEBUG -D_DATADIR='"/usr/share"' -pthread -g -O2 -D_REENTRANT -I/usr/include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/include/libxml2 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/pixman-1 linux/downloadqueue.cc
In file included from ./dcpp/File.h:26,
                 from ./dcpp/QueueManager.h:27,
                 from linux/downloadqueue.hh:27,
                 from linux/downloadqueue.cc:22:
./dcpp/Streams.h: In member function ‘virtual size_t dcpp::LimitedOutputStream<managed>::write(const void*, size_t)’:
./dcpp/Streams.h:140: warning: there are no arguments to ‘_’ that depend on a template parameter, so a declaration of ‘_’ must be available
g++ -o build/release/gui/entry.o -c -g -O2 -I. -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_REENTRANT -fpermissive -DHAVE_IFADDRS_H -O3 -fomit-frame-pointer -DNDEBUG -D_DATADIR='"/usr/share"' -pthread -g -O2 -D_REENTRANT -I/usr/include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/include/libxml2 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/pixman-1 linux/entry.cc

g++ -o build/release/gui/mainwindow.o -c -g -O2 -I. -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_REENTRANT -fpermissive -DHAVE_IFADDRS_H -O3 -fomit-frame-pointer -DNDEBUG -D_DATADIR='"/usr/share"' -pthread -g -O2 -D_REENTRANT -I/usr/include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/include/libxml2 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/pixman-1 linux/mainwindow.cc
In file included from ./dcpp/File.h:26,
                 from ./dcpp/UserConnection.h:28,
                 from ./dcpp/ConnectionManager.h:24,
                 from linux/mainwindow.hh:27,
                 from linux/mainwindow.cc:22:
./dcpp/Streams.h: In member function ‘virtual size_t dcpp::LimitedOutputStream<managed>::write(const void*, size_t)’:
./dcpp/Streams.h:140: warning: there are no arguments to ‘_’ that depend on a template parameter, so a declaration of ‘_’ must be available
g++ -o build/release/gui/privatemessage.o -c -g -O2 -I. -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_REENTRANT -fpermissive -DHAVE_IFADDRS_H -O3 -fomit-frame-pointer -DNDEBUG -D_DATADIR='"/usr/share"' -pthread -g -O2 -D_REENTRANT -I/usr/include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/include/libxml2 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/incl...

[Steven Sheehy (steven-sheehy)]

We were only fixing the build error, not the warning. The warning is a bit more complex to fix and requires core changes.