Quassel displays blank notifications if < > or & is in text

[Mackenzie Morgan]

Impact:
Notifications fsent from Quassel to KNotify which contain "<" ">" or "&" are parsed as broken HTML so the notifications do not display any message at all, just the sender's name.

Explanation:
The upstream patch catches characters that could be present in HTML tags and escapes them.

TEST CASE:
Open Quassel on one computer and put it on an inactive desktop. From another computer, send a message highlighting the user that is logged on in Quassel with text containing problematic characters, like "<3 Quassel". Only the sender's nick will be displayed in the notification. The text "<3 Quassel" will not.

I do not see any regression potential as the patch is very simple and straightforward.

[Scott Kitterman (kitterman)]

Is this in their 0.4.2 branch.

[Martin Pitt (pitti)]

The uploaded fix looks weird: it changes the existing debian/patches/notification-fix.patch to do

- QString message = QString("<b>&lt;%1&gt;</b> %2").arg(n.sender, n.message);
+ QString message = QString("<b>&lt;%1&gt;</b> %2").arg(n.sender, Qt::escape(n.message));

and then adds a new patch debian/patches/unblank_notifications.patch which _also_ does above change (plus some others). Also, the changelog does not document the change in notification-fix.patch

Please check this again.

[Scott Kitterman (kitterman)]

I think I know what happened. I'll redo it.

[Jonathan Thomas (echidnaman)]

Fixed in karmic/trunk.

[Alex Valavanis (valavanisalex)]

Jaunty reached end-of-life on 23 October 2010, so this bug will not be fixed in that version of Ubuntu. It has been fixed in newer versions.