[DM] Fix for ZTUtils.Zope.make_query()

Bug #373596 reported by Andreas Jung
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zope 2
Invalid
Undecided
Andreas Jung

Bug Description

2. Introduction

ZTUtils.Zope.make_query is supposed to create query strings. Query strings require quoting by urllib.quote_plus (not urllib.quote).

Revision history for this message
Andreas Jung (ajung) wrote :
Changed in zope2:
assignee: nobody → Andreas Jung (ajung)
Revision history for this message
ChrisW (chris-simplistix) wrote :

Why is quote_plus needed?
urllib.quote generates perfectly valid urls, it just uses %20 instead of +.

Changed in zope2:
status: New → Confirmed
Revision history for this message
Christian Zagrodnick (zagy) wrote :

I also don't see what the problem with quote's %20 quoting is. %20 works perfectly well.

Changed in zope2:
status: Confirmed → Incomplete
Revision history for this message
Christian Zagrodnick (zagy) wrote :

http://www.rfc-editor.org/rfc/rfc1630.txt states:

      Within the query string, the plus sign is reserved as shorthand
      notation for a space. Therefore, real plus signs must be encoded.
      This method was used to make query URIs easier to pass in systems
      which did not allow spaces.

Changed in zope2:
status: Incomplete → Invalid
Revision history for this message
Christian Zagrodnick (zagy) wrote :

(to clarify: the RFC states that + can be used for space, but doesn't need to be used. So I don't see any reason to change Zope here.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.