missing about icon in win32

[theAdib]

The Icon for the about menu entry on win32 is missing see the sceenshot

[nightrow (jb-benoit)]

Using inkscape 0.46 on WinXP, the icon is displayed at it should.

[theAdib (theadib)]

sorry, I mean the current development version. ie. version from date 20090504.

[jazzynico (jazzynico)]

Confirmed on Vista, Inkscape build 21271.

[Alvin Penner (apenner)]

- confirmed on Windows XP as well in build 21271
- this icon was visible previously in build 21210

[LucaDC (lucadc)]

Probably you already know, but when you open the Help menu (where the icon is missing) the console says:

(inkscape.exe:2672): GLib-CRITICAL **: g_convert: assertion `str != NULL' failed
(inkscape.exe:2672): GLib-GIO-CRITICAL **: g_loadable_icon_load: assertion `G_IS_LOADABLE_ICON (icon)' failed
(inkscape.exe:2672): GLib-CRITICAL **: g_convert: assertion `str != NULL' failed
(inkscape.exe:2672): GLib-GIO-CRITICAL **: g_loadable_icon_load: assertion `G_IS_LOADABLE_ICON (icon)' failed

Win XP SP3, SVN 21297.

[Lorenz Aebi (inkscape-xca)]

if you copy the icon inkscape.png or inkscape.svg from the folder /share/icons/tango/scalable to the folder /share/icons/tango/scalable/places if you do this for every possibility then the icons are shown correct.

I don't know how to solve this problem. There is a problem in the paths definition (Makefile.am).

[Lorenz Aebi (inkscape-xca)]

the index.theme file is wrong.

[Lorenz Aebi (inkscape-xca)]

next try:

remove the inkscape.svg file in the inkscape\share\icons folder. Then it works on my pc.

[Alvin Penner (apenner)]

thanks, removing inkscape.svg works for me as well on Windows XP, build 21345.

Now, if only we knew why...

[Lorenz Aebi (inkscape-xca)]

what i found is that the problem is in the widgets\icon.cpp file. i did a patch, but i really don't know if this is correct like this. at least it compiles, inkscape starts up and the icon is shown...

[Lorenz Aebi (inkscape-xca)]

i did some research but i don't know why we need the "static std::set<Glib::ustring> internalNames" variable. Can anybody explain me?

Because with out this variable the program is still working. See patch

[su_v (suv-lp)]

Happens on MacOS X 10.5.7 with Inkscape 0.47pre0 r21549, built Jun 13 2009 as well.

My guess is, it's related to the icon name/id (mismatch with hardcoded name in src?)
  id = "inkscape"
  inkscape:label = "#inkscape_options"
in icons.svg. tweenk or joncruz ought to have a look at this!

Don't remove that file - AFAIK hicolor (tango) icons will not be included in 0.47, and all inkscape 0.47 icons are in 'icons/icons.svg', as in earlier releases.

[su_v (suv-lp)]

Argh, I overlooked the filename 'inkscake.svg' in previous comments (7,9,10)
Renaming 'icons/inkscape.svg' forces Inkscape 0.47pre0 to load the about-icon from 'icons/icons.svg', which renders fine.

Builds with certain build/platform configurations (gtk/gio, librsvg?) seem to fail to load the scalable inkscape icon (orig size: 128x128 px, rendered size in menu 16x16 px). At least that's the main difference between r21525 (from modevia, JiHO) and 0.47pre0 r21549 (from sourceforge, mjwybrow) builds for OS X - I could not find SVN commits between 21525 and 21549 relevant to the widget/icon mechanism.

I compared the icon debug output (as descibed in http://wiki.inkscape.org/wiki/index.php/Icons#Debug_Output) between

  Inkscape 0.46+devel r21525 (about-icon is displayed)
  Inkscape 0.47pre0 r21549 (about-icon is missing)

Both are locally configured to use 'icons/icons.svg' and not the hicolor named icon theme.
output regarding the 'about-icon' (for both the same except the 0x value):

** Message: gtk_image_new_from_icon_name( 'inkscape', 1 ) = 0x45a2d68
** Message: Type is 7 ok
<…>
** Message: prerender_icon [inkscape] 16 NOT!!!!!!

The only relevant differences are (as in comment #6 already mentioned) messages from Inkscape 0.47pre0, they occur when opening the help menu:

(inkscape-bin:3341): GLib-GIO-CRITICAL **: g_loadable_icon_load: assertion `G_IS_LOADABLE_ICON (icon)' failed
(inkscape-bin:3341): GLib-GIO-CRITICAL **: g_loadable_icon_load: assertion `G_IS_LOADABLE_ICON (icon)' failed

[Alvin Penner (apenner)]

just writing to reaffirm that this bug is still present in the Windows build (7z file) for 0.47pre0 , July 2.

This is a very visible bug, for anyone trying to get help on Inkscape...

[Alvin Penner (apenner)]

just writing to reaffirm that this bug is still present in the Windows build (7z file) for 0.47pre1 , July 3.

[su_v (suv-lp)]

confirmed with Inkscape 0.47pre1 r21720, built Jul 20 2009 on OS X 10.5.7

[su_v (suv-lp)]

just built Inkscape r21924 on OS X 10.5.7:
librsvg (i.e. on osx: port install librsvg) installs the 'svg_loader'
module and adds 'svg' back to the list in 'gdk-pixbuf.loaders'. Both are
included into the application bundle (packaging process after
re-building). It seems to fix this bug: the about-icon is correctly
rendered, no more console warnings when opening the help menu.

test:
1) install librsvg via MacPorts

| LeWitt:~ suv$ port installed | grep librsvg
| librsvg @2.26.0_0 (active)

2) rebuild Inkscape, create application bundle
   run Inkscape.app: the about-icon is correctly rendered
3) quit Inkscape
   in 'Contents/Resources/etc/gtk-2.0/gdk-pixbuf.loaders'
   comment out the lines:

| "${CWD}/lib/gtk-2.0/2.10.0/loaders/svg_loader.so"
| "svg" 2 "gtk20" "Scalable Vector Graphics" "LGPL"
| "image/svg+xml" "image/svg" "image/svg-xml" "image/vnd.adobe.svg+xml"
| "text/xml-svg" "image/svg+xml-compressed" ""
| "svg" "svgz" "svg.gz" ""
| " <svg" "* " 100
| " <!DOCTYPE svg" "* " 100

4) restart Inkscape.app

result:
the about-icon is again missing.

Unfortunately I don't know if this relates in any way to the issue
(missing about-icon) with Windows builds.

[Krzysztof Kosinski (tweenk)]

It looks like the GTK function gtk_icon_theme_has_icon is slightly broken, as it returns true if only an SVG icon exists for the given name but the SVG loader is not installed. The possible solutions are:

a) bundle librsvg on Windows and Mac OS
b) change the call to gtk_icon_theme_has_icon in widgets/icon.h to gtk_icon_theme_lookup_icon

I have to finish my GSoC project so I can't test those solutions properly.

[su_v (suv-lp)]

SVN rev. 21987 commits a workaround (renaming 'inkscape' to 'inkscape-logo' in icons.svg and changing the icon remapping) to fix the issue (mainly for win32) - but the underlaying cause of the missling librsvg / SVG loader (as confirmed by Krzysztof) still needs to be addressed and fixed in my opinion.

[Alvin Penner (apenner)]

thanks, ~suv and Krzysztof,
that patch is working well in the Windows version of 0.47pre2

[su_v (suv-lp)]

@Alvin - the workaround was committed by Chris Morgan. The underlying issue is not yet addressed...