ask 2 times when selecting midi maps through keyboard

[vladimir prieto]

this is a not a critical bug.

when using only keyboard to access preferences and then select a new midi map, it ask "for sure" 2 times. doing this by mouse, it ask only one time.

[Albert Santoni (gamegod)]

Can you please list some explicit steps in order to reproduce the problem?

When I do this, I only get asked once:
1) Open MIDI bindings dialog by clicking on the name of my MIDI device in the preferences
2) Hit tab a couple of times to select the "Load Preset" combobox.
3) Hit the down arrow on my keyboard once to select the BCD3000 mapping.

At this point, it immediately asks me if I want to load that mapping. This behaviour is slightly broken because if you wanted to select anything other than the top element, if would try to load the mapping for each element you scrolled through in the list. We sort of need a "load preset" button for after the selection in the combox is done, but I won't fix that right now.

Regardless, the problem I listed above doesn't quite sound like what you're talking about. Can you elaborate more?

Thanks.

[vladimir prieto (vladimirprieto)]

On Sun, May 3, 2009 at 12:20 PM, Albert Santoni <email address hidden> wrote:

> Can you please list some explicit steps in order to reproduce the
> problem?

ok, in fact is very close that the ones you describe...let's c:

> 1) Open MIDI bindings dialog by clicking on the name of my MIDI device in
> the preferences

i do the same but with keyboard, by hit arrows, tabs...

> 2) Hit tab a couple of times to select the "Load Preset" combobox.

the same...

> 3) Hit the down arrow on my keyboard once to select the BCD3000 mapping.

yeah...but before hit the down arrow, i hit space bar to show the complete
list. then i hit down arrow. when cursor is over my midi mapping i hit
enter.

after that, it ask me to load that mapping, i hit yes (keyboard) and then it
ask me again.

try it and tell me if you get the same

--
Vladimir Prieto Muñoz
http://vladimir.prie.to
http://www.micontrol.cl

[vladimir prieto (vladimirprieto)]

> Can you please list some explicit steps in order to reproduce the
> problem?

ok, in fact is very close that the ones you describe...let's c:

> 1) Open MIDI bindings dialog by clicking on the name of my MIDI device in the preferences

i do the same but with keyboard, by hit arrows, tabs...

> 2) Hit tab a couple of times to select the "Load Preset" combobox.

the same...

> 3) Hit the down arrow on my keyboard once to select the BCD3000 mapping.

yeah...but before hit the down arrow, i hit space bar to show the complete list. then i hit down arrow. when cursor is over my midi mapping i hit enter.

after that, it ask me to load that mapping, i hit yes (keyboard) and then it ask me again.

try it and tell me if you get the same

[RJ Skerry-Ryan (rryan)]

Looked into this a bit, apparently the activate() signal of the QComboBox fires twice when you use the keyboard. This happens with the dialog box and without, so it isn't some weird interaction between the dialog and the QComboBox.

This seems to be related to us setting the dialog box index back to 0 at the end of slotLoadMidiMapping -- if I turn that off then the problem doesn't occur.

[Sean M. Pappalardo (pegasus-renegadetech)]

RJ: so is that a fix or does that break something else?

[Sean M. Pappalardo (pegasus-renegadetech)]

This problem is gone as of v1.7.2 on Linux and Windows in my testing. Vladimir, please test with Mixxx 1.7.2 and let us know if you still have the problem.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5160