Libnotify plugin does not properly render names with '&' in title

[Abhishek Mukherjee]

Songs with an & in the title are encoded as & before being passed to libnotify. NotifyOSD at the very least will therefore print out the title as "Always & Never", not the expected "Always & Never". It must be investigated of how the different Galago daemons receive this. NotifyOSD apparently will print it verbatim but do others (read: notification-daemon) do the same?

[mlissner (mlissner-michaeljaylissner)]

I can confirm this result using v. 0.2.14.

[Abhishek Mukherjee (linkinpark342)]

@mlissner
What notification system are you using?

A quick notify-send on my computer (now that i have time to think of such things) shows notification-daemon prints everything verbatim as well. I think the solution is just to not escape the summary since those two systems are the only galago things I can think of (i heard awn might have one as well).

Attached patch seems to fix for notification-daemon and (likely) NotifyOSD as well. I've stress tested this patch on a smorgasborg of songs. and by smorgasborg i mean exactly two songs. The patch is against the 0.3.x branch

[mlissner (mlissner-michaeljaylissner)]

If I said libnotify 0.4.5 on Ubuntu Jaunty, would that answer your question?

[Abhishek Mukherjee (linkinpark342)]

You're probably using NotifyOSD. I'll install that AWN thingie and see if the patch fixes it later today.

[reacocard (reacocard)]

committed r1866