Button labels are unclear

[Didier Raboud]

For reporting a bug, I wanted to change my KDE (QT) language to english. I can select the language, but [OK] doesn't close it and I have to clic on [Cancel] (in fact, my language selector is in french at that moment).

In fact, the preference seems to be remembered as when I came back, my selection had been holded.

[Kari Oikarinen (kluge)]

I can confirm this on an up-to-date Dapper. OK doesn't seem to do anything, here's what gets printed onto terminal:

updateLanguageList()
tristate: English
updateSystemDefaultCombox()
locale:
Cannot set LC_CTYPE to default locale
: No such file or directory

locale:
Cannot set LC_MESSAGES to default locale
: No such file or directory

locale:
Cannot set LC_COLLATE to default locale
: No such file or directory

found default: Finnish (Finland)
onPushButtonOk(self)
onPushButtonOk(self)
onPushButtonOk(self)
onPushButtonOk(self)

(I pressed OK four times.)
Version: 0.1.15
I'm using an AMD64 system if that matters.

[Frank Bob (frankbob)]

I can confirm this as well. Ok doesn't work

running dapper kubuntu up to date as of April 3rd 2006

[Michael Vogt (mvo)]

[OK] means apply in this app, it seems like this is a unfortunate choice. The changes are applied after you pressed Ok, but it didn't closed.

What does the kde/qt style-guide say about the behaviour for apps? Should I have a [apply] button? Or should [ok] close the app (after applying the action)?

Cheers,
 Michael

[Michael Vogt (mvo)]

Jonathan suggested to reanme the buttons "close" and "install". Because you can also change the default language environment with it, I guess "close" and "apply" is appropriate. What do you think?

[Kari Oikarinen (kluge)]

"Close" and "Apply" sound good to me.

Also, it would be nice to have some sort of feedback like "All requested language packs are already installed.". Now I assumed it didn't work. But (tried with another language) it seems to work fine.

[Michael Vogt (mvo)]

The button labels are fixed in the current dapper version.