syncdaemon fs.move_to_conflict will fail if the file is not found

[Lucio Torre]

009-05-01 11:33:17,388 - ubuntuone.SyncDaemon.sync - DEBUG - T:LOCAL:F None [root:None] ''My Files/Documents/Finances/VanDineFamily.20090422000454.log'' | EVENT: AQ_FILE_NEW_ERROR:{'not_available': 'F', 'not_authorized': 'F'} with ARGS:('DOES_NOT_EXIST',)
2009-05-01 11:33:17,391 - ubuntuone.SyncDaemon.sync - DEBUG - T:LOCAL:F None [root:None] ''My Files/Documents/Finances/VanDineFamily.20090422000454.log'' | Calling file_not_created_remove
2009-05-01 11:33:17,391 - ubuntuone.SyncDaemon.fsm - INFO - move_to_conflict: path='/home/ken/Ubuntu One/My Files/Documents/Finances/VanDineFamily.20090422000454.log' mdid='451611c6-1159-4ad2-a83e-a2816160ddc6'
2009-05-01 11:33:17,393 - ubuntuone.SyncDaemon.sync - ERROR - T:LOCAL:F None [root:None] ''My Files/Documents/Finances/VanDineFamily.20090422000454.log'' | Executing ACTION_FUNC 'file_not_created_remove' gave an exception
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/canonical/ubuntuone/storage/syncdaemon/fsm/fsm.py", line 135, in on_event
    af(event_name, parameters, *args)
  File "/usr/lib/python2.6/dist-packages/canonical/ubuntuone/storage/syncdaemon/sync.py", line 652, in file_not_created_remove
    self.key.move_to_conflict()
  File "/usr/lib/python2.6/dist-packages/canonical/ubuntuone/storage/syncdaemon/sync.py", line 161, in move_to_conflict
    self.fs.move_to_conflict(self.get_mdid())
  File "/usr/lib/python2.6/dist-packages/canonical/ubuntuone/storage/syncdaemon/filesystem_manager.py", line 512, in move_to_conflict
    os.rename(path, to_path)
OSError: [Errno 2] No such file or directory

[Lucio Torre (lucio.torre)]

do we change move_to_conflic or i catch that? will the metadata be clean if it raises this?

[Lucio Torre (lucio.torre)]

do we change move_to_conflic or should i catch that? will the metadata be clean if it raises this?

[Facundo Batista (facundo)]

There's the possibility of that what we're trying to move is removed, so I'm handling it in FSM.