Launchpad itself

Only probe Ubuntu mirrors?

Bug #370329 reported by Curtis Hovey
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
William Grant
Launchpad itself 11.03

Bug Description

The mirror-prober script regularly fails...
    Mirror 'primary-baltix-download' of distribution 'baltix' can't be probed --we only probe Ubuntu mirrors.

If this message is the case, then users should not be permitted to add a mirror to a distribution other than Ubuntu. The prober should not try to probe a non-Ubuntu mirror if it receives one.

Related branches

lp:~wgrant/launchpad/silence-of-the-prober-ii
Tim Penhey (community): Approve (code)
Steve Kowalik (community): Approve (code*)
Diff: 98 lines (+27/-2)
4 files modified
lib/lp/registry/model/distributionmirror.py (+2/-1)
lib/lp/registry/scripts/distributionmirror_prober.py (+2/-1)
lib/lp/registry/tests/test_distributionmirror.py (+20/-0)
lib/lp/registry/tests/test_distributionmirror_prober.py (+3/-0)
Curtis Hovey (sinzui)
Changed in launchpad-registry:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Curtis Hovey (sinzui) wrote :

The answer is that any distribution may register a mirror to communicate where it can be downloads. The mirror-prober knows it cannot update non-Ubuntu mirrors, so it should ignore them.

Revision history for this message
Guilherme Salgado (salgado) wrote : Re: [Bug 370329] [NEW] Only probe Ubuntu mirrors?

On Fri, 2009-05-01 at 12:39 +0000, Curtis Hovey wrote:
> Public bug reported:
>
> The mirror-prober script regularly fails...
> Mirror 'primary-baltix-download' of distribution 'baltix' can't be probed --we only probe Ubuntu mirrors.
>

This is not a failure -- it's just informational log.

> If this message is the case, then users should not be permitted to add a
> mirror to a distribution other than Ubuntu. The prober should not try to
> probe a non-Ubuntu mirror if it receives one.

New mirrors can be registered only for Ubuntu, but in the past there was
a short period of time when it was possible to register mirrors for
other distros. That's how the primary-baltix-download was registered.

The mirror also prober ignores non-Ubuntu mirrors, so the only thing we
may have left to fix is making it clear that the message spilled by the
prober is just informational and not an error.

 subscribe

Revision history for this message
Curtis Hovey (sinzui) wrote :

I think we need to do more. Either we remove Baltix's mirror data, or we allow all distros to register a mirror (know that only Ubuntu gets probed).

Revision history for this message
William Grant (wgrant) wrote :

The log message is not useful. It should be reduced to DEBUG.

Changed in launchpad:
importance: Low → Critical
assignee: nobody → William Grant (wgrant)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r12408 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12408>.

Changed in launchpad:
milestone: none → 11.03
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-untestable
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.