Inline JavaScript in bug-portlet-subscribers.pt should be moved to bugtask-index.js
Bug #369874 reported by
Deryck Hodge
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Graham Binns | ||
Bug Description
In having to create a portlet object for firing a custom portlet loaded event, it became obvious that the inline portlet JavaScript in bug-portlet-
Related branches
lp:~gmb/launchpad/subscriber-portlet-timeout-bug-393476
- Abel Deuring (community): Approve (code)
-
Diff: 521 lines (+191/-95)11 files modifiedlib/canonical/launchpad/javascript/bugs/bugtask-index.js (+71/-4)
lib/lp/bugs/browser/bugsubscription.py (+9/-2)
lib/lp/bugs/browser/configure.zcml (+6/-0)
lib/lp/bugs/browser/tests/bug-portlet-subscribers-content.txt (+1/-1)
lib/lp/bugs/stories/bug-privacy/05-set-bug-private-as-admin.txt (+6/-3)
lib/lp/bugs/stories/bugs/bug-add-subscriber.txt (+4/-2)
lib/lp/bugs/stories/bugs/xx-bug-personal-subscriptions.txt (+35/-16)
lib/lp/bugs/templates/bug-portlet-dupe-subscribers-content.pt (+27/-0)
lib/lp/bugs/templates/bug-portlet-subscribers-content.pt (+8/-17)
lib/lp/bugs/templates/bug-portlet-subscribers.pt (+16/-46)
lib/lp/bugs/tests/bug.py (+8/-4)
| Changed in malone: | |
| importance: | Undecided → Medium |
| milestone: | none → 2.2.5 |
| Changed in malone: | |
| milestone: | 2.2.5 → 2.2.6 |
| status: | New → Triaged |
| Changed in malone: | |
| milestone: | 2.2.6 → 2.2.7 |
Revision history for this message
| Deryck Hodge (deryck) wrote | #1 |
| Changed in malone: | |
| importance: | Medium → Low |
| milestone: | 2.2.7 → none |
| tags: | added: tech-debt |
Revision history for this message
| Graham Binns (gmb) wrote | #2 |
| Changed in malone: | |
| assignee: | nobody → Graham Binns (gmb) |
| milestone: | none → 3.1.11 |
| status: | Triaged → In Progress |
Revision history for this message
| Diogo Matsubara (matsubara) wrote Bug fixed by a commit | #3 |
| Changed in malone: | |
| status: | In Progress → Fix Committed |
| Changed in malone: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Marking low since this can be picked up in any clean up or refactor that happens around UI work in the next two months. Likewise, no point in committing to a particular cycle right now.