searching the dav lock manager is broken

[Godefroid Chapelle]

Some searches in Dav lock manager fail :

Zope 2.10.7

2009-04-24T09:51:02 ERROR Zope.SiteErrorLog http://localhost:21080/Control_Panel/DavLocks/manage_main
Traceback (innermost last):
  Module ZPublisher.Publish, line 119, in publish
  Module ZPublisher.mapply, line 88, in mapply
  Module ZPublisher.Publish, line 42, in call_object
  Module Shared.DC.Scripts.Bindings, line 313, in __call__
  Module Shared.DC.Scripts.Bindings, line 350, in _bindAndExec
  Module App.special_dtml, line 178, in _exec
  Module DocumentTemplate.DT_Let, line 75, in render
  Module DocumentTemplate.DT_Util, line 196, in eval
   - __traceback_info__: from_path
  Module <string>, line 0, in ?
  Module App.DavLockManager, line 57, in findLockedObjects
  Module App.DavLockManager, line 103, in _findapply
  Module App.DavLockManager, line 103, in _findapply
  Module App.DavLockManager, line 103, in _findapply
  Module App.DavLockManager, line 103, in _findapply
  Module App.DavLockManager, line 98, in _findapply
  Module webdav.LockItem, line 104, in getCreatorPath
TypeError: unpack non-sequence

Line 104 of webdav.LockItem is :

        db, name = self._creator

self._creator is created with line 86 in same file

        self._creator = ownerInfo(creator)

line 296 of AccessControl.Owned :

def ownerInfo(user, getattr=getattr):
    if user is None:
        return None
    uid=user.getId()
    if uid is None: return uid

This shows that ownerInfo can return None (not a tuple).

Iow, getCreatorPath needs to be fixed to take this case in account.

I suspect that this has to do with anonymous locks...

If last sentence is right, as getCreatorPath is only used by Dav Lock Manager,

Adding

  if self._creator is None:
      return "anonymous lock"

before the unpacking should fix the problem.

[Colin Watson (cjwatson)]

The zope2 project on Launchpad has been archived at the request of the Zope developers (see https://answers.launchpad.net/launchpad/+question/683589 and https://answers.launchpad.net/launchpad/+question/685285). If this bug is still relevant, please refile it at https://github.com/zopefoundation/zope2.