wireless-ipw-power - does not detect wireless correctly (2.6.29)

Bug #369113 reported by Alon Bar-Lev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Laptop Mode Tools
Fix Released
Undecided
Ritesh Raj Sarraf

Bug Description

The following line at modules/wireless-ipw-power is not working properly:

 if [ -d $DEVICE/wireless -a -h $DEVICE/device/driver ]; then

 It looks like at least at 2.6.29 there is no wireless directory... I
 did not find anything unique in structure of a wired and wireless but
 the driver has channels.

 Maybe better to do iwconfig and check for wireless extensions?

 Another issue...

 Why doesn't ipw2200 has "iwpriv ethX set power Y" statement?

Ritesh Raj Sarraf (rrs)
Changed in laptop-mode-tools:
assignee: nobody → rickysarraf
status: New → In Progress
Revision history for this message
Ritesh Raj Sarraf (rrs) wrote :

This is another example why one shouldn't abuse the sysfs. sysfs was never meant to be used this way. And especially for frequent point release distributions like ubuntu/fedora, and rolling-release distributions like Debian, using sysfs will be a nightmare.

Anyway, I like the idea of using wireless-tools. I just did a brief check and found limitations with it. A bug and a patch has been filed here [1]. If the upstream author accepts, I'll change this from sysfs to something better, as time permits.

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=526187

Revision history for this message
Ritesh Raj Sarraf (rrs) wrote :

Good news is that the patch has a positive feedback from upstream

Revision history for this message
Alon Bar-Lev (alon-barlev) wrote :

Something simple as:
iwconfig $interface | grep '802\.11' > /dev/null 2>&1 && echo wireless

???

Revision history for this message
Ritesh Raj Sarraf (rrs) wrote :

That'd still misbehave when the device is not associated.

Revision history for this message
Ritesh Raj Sarraf (rrs) wrote :

Fixed. Will be part of next release.

Changed in laptop-mode-tools:
status: In Progress → Fix Committed
Revision history for this message
Ritesh Raj Sarraf (rrs) wrote :

1.49

Changed in laptop-mode-tools:
status: Fix Committed → Fix Released
Revision history for this message
Faustus (orlovm) wrote :

Just a comment.

config WIRELESS_EXT_SYSFS
    bool "Wireless extensions sysfs files"
    default y
    depends on WIRELESS_EXT && SYSFS
    help
      This option enables the deprecated wireless statistics
      files in /sys/class/net/*/wireless/. The same information
      is available via the ioctls as well.

      Say Y if you have programs using it, like old versions of
      hal.

See also #415719.

Revision history for this message
Ritesh Raj Sarraf (rrs) wrote : Re: [Bug 369113] Re: wireless-ipw-power - does not detect wireless correctly (2.6.29)

On Monday 18 Oct 2010 19:39:33 Faustus wrote:
> This option enables the deprecated wireless statistics
> files in /sys/class/net/*/wireless/. The same information
> is available via the ioctls as well.

I'm not sure what you mean here. Do you want the deprecated interface be
enabled ?

--
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.