rich root upgrade adds inconsistent parents/rich root parents are not evaluated correctly.

[Robert Collins]

The rich roots added by the upgrade process appear to be inconsistent:

The conversion appears to have introduced 23 inconsistent parents:
Pre:
  1145 revisions
   434 file-ids
  2045 unique file texts
 64520 repeated file texts
     0 unreferenced text versions

Post:
  1145 revisions
   435 file-ids
  2045 unique file texts
 64520 repeated file texts
     0 unreferenced text versions
    23 inconsistent parents

[Robert Collins (lifeless)]

This is fixed for the IDS code path but not the network fetch code path

[Andrew Bennetts (spiv)]

My lp:~spiv/bzr/inventory-delta branch has a fix for this, I think. The network fetch code path now uses the same code as IDS for this logic, so it generates the same parents for generated roots that IDS does (only heads, etc). It's almost Fix Committed rather than In Progress, but that branch isn't quite ready for landing yet.

[Andrew Bennetts (spiv)]

This should be fixed in all code paths in bzr.dev now, IIUC.