Update using repository does not work

Bug #367825 reported by Fabien Lydoire @ Taktik
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Server (MOVED TO GITHUB)
Status tracked in Trunk
5.0
Won't Fix
Undecided
Unassigned
Trunk
Invalid
Undecided
Unassigned

Bug Description

v5.0.0-3

The update of modules based on repositories can't work with current code.
Moreover, the repository packages are supposed to be <name of the module>-<version of the module><extension>
which is NOT the case in OpenERP own URLs

Proposed patch
--- bin/addons/base/module/module.py (revision 6806)
+++ bin/addons/base/module/module.py (working copy)
@@ -398,7 +398,7 @@
             if not download:
                 continue
             zipfile = urllib.urlopen(mod.url).read()
- fname = addons.get_module_path(mod.name+'.zip')
+ fname = addons.get_module_path_for_creation(mod.name+'.zip')
             try:
                 fp = file(fname, 'wb')
                 fp.write(zipfile)
===================================================================
--- bin/addons/__init__.py (revision 6806)
+++ bin/addons/__init__.py (working copy)
@@ -139,6 +139,9 @@
         return s

+def get_module_path_for_creation(module):
+ return opj(_ad,module)
+
 def get_module_path(module):
     """Return the path of the given module."""

Changed in openobject-server:
status: New → Confirmed
Revision history for this message
Richard (John) Nopkins@Servosoft (richard-nopkins) wrote :

Should not openerp change code? or the website naming convention?

Revision history for this message
Richard (John) Nopkins@Servosoft (richard-nopkins) wrote :

how can i assign this to anyone?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.