Preferences settings not always reported correctly to code
Bug #367752 reported by
Jon A. Cruz
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Inkscape |
Fix Released
|
Critical
|
Jon A. Cruz |
Bug Description
When working on other code, it was noticed that the icon code was never seeing "dumpDefault" as set to true. When the same places of code were switched to use the "overlaySvg" preference name, no change was observed.
http://
That is, the place in the code was always getting "false" as the result, no matter what was set in the preferences, and that those worked later in the same run within other areas of code.
It is critical that all code get proper values reported, no matter when that code is called. This can easily cascade to trigger problems across the entire codebase.
Changed in inkscape: | |
assignee: | nobody → tweenk |
importance: | Undecided → Critical |
milestone: | none → 0.47 |
status: | New → Confirmed |
Changed in inkscape: | |
assignee: | Krzysztof Kosiński (tweenk) → Jon A. Cruz (jon-joncruz) |
Changed in inkscape: | |
status: | Confirmed → In Progress |
To post a comment you must log in.
This class is a singleton, but the actual preferences are not loaded in the constructor nor the singleton accessor method. It appears that the safest route is to make the load() call private and move its invocation to the accessor method.