jpilot inserts bogus text in vCard export

[David Gibson]

Binary package hint: jpilot

The version of jpilot in Ubuntu 9.04 (that is jpilot 1.6.0-1) incorrectly exports to vcard format.

When exporting addresses to vcard format, jpilot it inserts an extra copy of the category information in front of
the FN: tag, meaning the vcf output is invalid.

i.e. it produces:
        BEGIN:VCARD
        VERSION:3.0
        PRODID:-//Judd Montgomery//NONSGML J-Pilot 1.6.0//EN
        UID:palm-addressbook-003430dd-000003e8-David Gibson@mulberryst
        CATEGORIES:Business
--> "Business",FN:ABN Amro Morgans
        N:ABN Amro Morgans
        ORG:ABN Amro Morgans
        TEL;TYPE=work,pref:6232 4999
        ADR:;;Level 1\, 25 Napier Close\, Deakin;;;;

        END:VCARD

When it should produce this:
        BEGIN:VCARD
        VERSION:3.0
        PRODID:-//Judd Montgomery//NONSGML J-Pilot 1.6.0//EN
        UID:palm-addressbook-003430dd-000003e8-David Gibson@mulberryst
        CATEGORIES:Business
--> FN:ABN Amro Morgans
        N:ABN Amro Morgans
        ORG:ABN Amro Morgans
        TEL;TYPE=work,pref:6232 4999
        ADR:;;Level 1\, 25 Napier Close\, Deakin;;;;

        END:VCARD

I've located the source of the problem, it's in address_gui.c:
         utf = charset_p2newj(contact_app_info.category.name[mcont->attrib & 0x0F], 16, char_set);
         str_to_vcard_str(csv_text, sizeof(csv_text), utf);
         fprintf(out, "CATEGORIES:%s%s", csv_text, CRLF);
         fprintf(out, "\"%s\",", utf);
         g_free(utf);

The last fprintf() line is bogus and should be removed. This problem is also in jpilot's upstream CVS.

[Ludovic Rousseau (ludovic-rousseau-gmail)]

Now fixed upstream in CVS version 1.229
http://lists.jpilot.org/pipermail/jpilot-commits/2009-April/000000.html

Will be fixed in Debian unstable soon.

[Ludovic Rousseau (ludovic-rousseau-gmail)]

Fixed in Debian package version 1.6.2.3-1.

I don't know when the Ubuntu package will be rsynchronized with the Debian one.

[Ludovic Rousseau (ludovic-rousseau-gmail)]

natty now has version 1.8.0.2.
Closing the bug report.