Firefox rounds GNOME default font size down to an integer

[Anders Kaseorg]

Binary package hint: firefox-3.0

I set my GNOME default font size to 7.5, but Firefox (3.0 and 3.5 on Jaunty, as well as many previous versions) displays the menu and toolbars at font size 7. Testing with other values indicates that Firefox always rounds fractional UI font sizes down to the next integer.

[Timeless-bemail (timeless-bemail)]

heh

[L. David Baron (dbaron)]

->blizzard

[Felix Miata (mrmazda)]

Only component owners, peers, and drivers may set + flags on blocking. If you
wish blocking considered, set ? on the flag. Unlikely an unconfirmed bug will
block anything though.

[Gervase Markham (gerv-mozilla)]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox: http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey: http://www.mozilla.org/projects/seamonkey/

[Mats Palmgren (matspal)]

Does this bug still occur in a recent trunk build?
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/

[Ross Burton (ross)]

Yes, it does.

[Anders Kaseorg (andersk)]

Binary package hint: firefox-3.0

I set my GNOME default font size to 7.5, but Firefox (3.0 and 3.5 on Jaunty, as well as many previous versions) displays the menu and toolbars at font size 7. Testing with other values indicates that Firefox always rounds fractional UI font sizes down to the next integer.

[Anders Kaseorg (andersk)]

This still happens in Firefox 3.0 and 3.5 on Jaunty.

[Anders Kaseorg (andersk)]

I spotted this mistake, which I bet is responsible for this bug:

--- xulrunner-1.9.0.9.orig/mozilla/gfx/src/thebes/nsSystemFontsGTK2.cpp
+++ xulrunner-1.9.0.9/mozilla/gfx/src/thebes/nsSystemFontsGTK2.cpp
@@ -210,7 +210,7 @@

     aFontStyle->weight = pango_font_description_get_weight(desc);

- float size = float(pango_font_description_get_size(desc) / PANGO_SCALE);
+ float size = float(pango_font_description_get_size(desc)) / PANGO_SCALE;

     // |size| is now either pixels or pango-points (not Mozilla-points!)

[Anders Kaseorg (andersk)]

Created attachment 374580
cast to float before integer division, not after
[Checkin: Comment 14]

Yeah, that does the trick. Tested in xulrunner 1.9.1 and firefox 3.5 on Jaunty. Here’s the same patch as an attachment.

[Blizzard (blizzard)]

Comment on attachment 374580
cast to float before integer division, not after
[Checkin: Comment 14]

Wow, yeah, that's a bug. Good find.

[Blizzard (blizzard)]

Roc - cheap and easy fix for linux. Can you give a quick sr?

[Roc-ocallahan (roc-ocallahan)]

Comment on attachment 374580
cast to float before integer division, not after
[Checkin: Comment 14]

sr not needed here

[Blizzard (blizzard)]

I'm old-school. Back where I come from it all needs an sr. :)

[Sgautherie-bz (sgautherie-bz)]

Comment on attachment 374580
cast to float before integer division, not after
[Checkin: Comment 14]

http://hg.mozilla.org/mozilla-central/rev/4561d478f6ba

[Dao (dao)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b8574ac1c849

[Micah Gersten (micahg)]

Firefox 3.0 is only receiving Security Updates and major bug fixes at this point.

[Micah Gersten (micahg)]

This was fixed in the initial release version of Firefox 3.5. Please report any other bugs you may find.