Community add tags ignored

[Chris McDonough]

When adding a new community, the tags you input within the "Tags" field on the add form are ignored; or at least the tags stuff doesn't show them when you visit the community (it's possible to re-add it afterwards on the Overview screen)

[Paul Everitt (paul-agendaless)]

Tres, not sure if this goes to you or Balazs.

[Tres Seaver (tseaver)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Paul Everitt wrote:
> Tres, not sure if this goes to you or Balazs.
>
> ** Changed in: karl3
> Importance: Undecided => Low
>
> ** Changed in: karl3
> Milestone: None => m11
> Assignee: (unassigned) => Tres Seaver (tseaver)
>

I added a test that 'tags', if present in the request, were being saved.
 I then put a pdb.set_trace inside add_community_view, and found that
'tags' was not being passed into the request:

 (pdb) print request.POST.keys()
 ['title', 'description', 'text_text_format', 'text', 'sharing', 'blog',
 'wiki', 'calendar', 'files', 'form.submitted']

I don't understand the Javascript fragment associated with the tags
field, so I'm guessing this is for Balasz.

  assign ree

Tres.
- --
===================================================================
Tres Seaver [phone] <email address hidden>
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJ8HlE+gerLs4ltQ4RAgsOAJ9k90+KmJUPNl13DEDJnSINSRaGNACgzFZF
/j3yuVJQvuMyB+KjL/XdlMA=
=Pjo+
-----END PGP SIGNATURE-----

[Balazs Ree (ree)]

Thanks, I take this over and got back with questions if the server side is deeply involved with the problem (unlikely).

[Balazs Ree (ree)]

Hi Tres, can you please check if it works now?

I fixed a missing home-url -> app-url conversion that affected the tagsearch. This means I did not really do anything to fix the actual tag-adding problem.

but nevertheless I see this:

 /home/ree/work/osi/k3/gf/karl-trunk/karl/views/communities.py(197)add_community_view()
-> set_tags(community, request, converted['tags'])
(Pdb) converted
{'text': u'', 'sharing': False, 'title': u'lalala', 'description': u'dududu', 'tags': [u'karl']}

Which means the tags were taken out correctly from the form. And I see the tags appear in the newly created community. In this case at least.

If the problem still persists, can you please reopen the ticket and help me further to reproduce the bug?

[Tres Seaver (tseaver)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Balazs Ree wrote:
> Hi Tres, can you please check if it works now?
>
> I fixed a missing home-url -> app-url conversion that affected the
> tagsearch. This means I did not really do anything to fix the actual
> tag-adding problem.
>
> but nevertheless I see this:
>
> /home/ree/work/osi/k3/gf/karl-trunk/karl/views/communities.py(197)add_community_view()
> -> set_tags(community, request, converted['tags'])
> (Pdb) converted
> {'text': u'', 'sharing': False, 'title': u'lalala', 'description': u'dududu', 'tags': [u'karl']}
>
> Which means the tags were taken out correctly from the form. And I see
> the tags appear in the newly created community. In this case at least.
>
> If the problem still persists, can you please reopen the ticket and help
> me further to reproduce the bug?

 status inwork

The UI here is broken, subtly: putting a tag value in the input field
and then submitting the entire form results in a posted form without
'tags'::

 (Pdb) print request.POST.keys()
 ['title', 'description', 'text_text_format', 'text', \
  'sharing', 'blog', 'wiki', 'calendar', 'files', 'form.submitted']

Clicking the "Add" button next to the tags input field *before* posting
the form yields a form post *with* 'tags'::

 (Pdb) print request.POST.keys()
 ['title', 'tags', 'description', 'text_text_format', 'text', \
  'sharing', 'blog', 'wiki', 'calendar', 'files', 'form.submitted']

I think this is a bug magnet: we should just remove the 'tags' field
altogether from the add_communities form, and let people tag things only
after creation.

Tres.
- --
===================================================================
Tres Seaver [phone] <email address hidden>
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJ9KZN+gerLs4ltQ4RAk26AJ0Ryr14o1RzgN8C/7zAEV5PwoFpkgCfeS/O
v0kuPnw8wNywhglmLQbqOp8=
=e5is
-----END PGP SIGNATURE-----

[Tres Seaver (tseaver)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Balazs Ree wrote:
> Hi Tres, can you please check if it works now?
>
> I fixed a missing home-url -> app-url conversion that affected the
> tagsearch. This means I did not really do anything to fix the actual
> tag-adding problem.
>
> but nevertheless I see this:
>
> /home/ree/work/osi/k3/gf/karl-trunk/karl/views/communities.py(197)add_community_view()
> -> set_tags(community, request, converted['tags'])
> (Pdb) converted
> {'text': u'', 'sharing': False, 'title': u'lalala', 'description': u'dududu', 'tags': [u'karl']}
>
> Which means the tags were taken out correctly from the form. And I see
> the tags appear in the newly created community. In this case at least.
>
> If the problem still persists, can you please reopen the ticket and help
> me further to reproduce the bug?

 status inprogress

The UI here is broken, subtly: putting a tag value in the input field
and then submitting the entire form results in a posted form without
'tags'::

 (Pdb) print request.POST.keys()
 ['title', 'description', 'text_text_format', 'text', \
  'sharing', 'blog', 'wiki', 'calendar', 'files', 'form.submitted']

Clicking the "Add" button next to the tags input field *before* posting
the form yields a form post *with* 'tags'::

 (Pdb) print request.POST.keys()
 ['title', 'tags', 'description', 'text_text_format', 'text', \
  'sharing', 'blog', 'wiki', 'calendar', 'files', 'form.submitted']

I think this is a bug magnet: we should just remove the 'tags' field
altogether from the add_communities form, and let people tag things only
after creation.

Tres.
- --
===================================================================
Tres Seaver [phone] <email address hidden>
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJ9KeC+gerLs4ltQ4RAlvPAKCE8uUsZzOZKj7kuL1oGhRfnlB3pgCg0NIt
cfFXADS/Bm2BB9OrqfCBqJM=
=Yp9O
-----END PGP SIGNATURE-----

[Paul Everitt (paul-agendaless)]

On Apr 26, 2009, at 2:27 PM, Tres Seaver wrote:
>
> I think this is a bug magnet: we should just remove the 'tags' field
> altogether from the add_communities form, and let people tag things
> only
> after creation.

OSI specifically wanted this feature (tagging during adding). In
fact, we had it in KARL1, briefly, but the behavior wasn't quite right
so we disabled it.

I'll read through the transcript more closely and see if this is best
done with some cleanup in the FormEncode validator and its connection
to the view.

--Paul

[Paul Everitt (paul-agendaless)]

Thinking back on it, I can live with the feature-sloppiness of the issue Tres mentioned. It somewhat mimics the behavior of tagging in KARL2: simply typing a value in the box isn't enough. You have to hit enter or click Add for the tag to be saved.

I think the real issue is the stupid "Add" button. I know Yalan tripped on it. The wording, and the concept of the button, needs revisiting. We were just translating the K1/K2 spec.