The file name is not displayed in Layout / Region Options

Bug #361125 reported by ldsonline
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Xibo
Fix Released
Low
Alex Harrington
1.0
Fix Released
Low
Alex Harrington
1.1
Fix Released
Low
Alex Harrington

Bug Description

The file name is not displayed after it is added to the layout (see image attached), it is not possible to know what will be displayed.

Related branches

Revision history for this message
ldsonline (ldsonline) wrote :
Revision history for this message
Alex Harrington (alexharrington) wrote :

Confirmed on my 1.0.0-final production.

Changed in xibo:
importance: Undecided → Medium
milestone: none → 1.0.1
status: New → Confirmed
Revision history for this message
Alex Harrington (alexharrington) wrote :

I had a quick look at this this evening.

It's not a bug in the display code. It looks to me like we're querying the xlf in the database for a name attribute on the media, but the name attribute was removed when we reworked the xlf structures.

It could be fixed with an additional database query...

Pertinent section is
http://bazaar.launchpad.net/~xibo-maintainers/xibo/halley/annotate/head%3A/server/lib/pages/layout.class.php#L1323
http://wiki.xibo.org.uk/wiki/XML_Schema_Examples

Attached patch solves this for me, but I'm not sure if it's the way you want to handle it Dan?

Changed in xibo:
status: Confirmed → Triaged
Revision history for this message
Dan Garner (dangarner) wrote :

The correct way to do it would be to create an object of that media type and get the name from that - this is because different media types store their names in different places.

Seems like overkill but its a better implementation...

That would require some more information to be made available through the module class (and its interface to ensure each module had an implementation) .

Maybe for the time being use your fix (conditional based on media type)? And create a blueprint to extend the module implementation in 1.1?

Revision history for this message
Alex Harrington (alexharrington) wrote :

In 1.0, where else are they storing names then?

Changed in xibo:
status: Triaged → In Progress
assignee: nobody → alexharrington
Changed in xibo:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.