nm-connection-editor crashs after clicking Cancel in the "add new connection" dialog

[Ricardo Pérez López]

Binary package hint: network-manager

Steps to reproduce:

1. Open the Network Manager Connection Editor (nm-connection-editor), either from a terminal or right-clicking on the NM applet in the notification area.
2. Select one of the following tabs: Wired, Wireless or DSL.
3. Click on Add.
4. In the dialog that appears, click on Cancel.

Expected behavior: the dialog closes and you come back to the nm-connection-editor main window.

Actual behaviour: nm-connection-editor crashes with a core dump.

The bug is totally reproducible in my fully updated Jaunty:

$ LC_ALL=C nm-connection-editor

(nm-connection-editor:13181): GLib-CRITICAL **: g_hash_table_foreach: assertion `hash_table != NULL' failed

** (nm-connection-editor:13181): WARNING **: nm_connection_list_new: failed to load VPN plugins: Couldn't read VPN .name files directory /etc/NetworkManager/VPN.
**
ERROR:nm-connection-list.c:787:add_done_cb: code should not be reached
Cancelado (core dumped)

[Alexander Sack (asac)]

patch

=== modified file 'ChangeLog'
--- a/ChangeLog 2009-04-13 13:21:42 +0000
+++ b/ChangeLog 2009-04-15 14:15:20 +0000
@@ -1,8 +1,14 @@
[phone] Alexander Sack <email address hidden>
+
+ * src/connection-editor/nm-connection-list.c
+ - (add_done_cb): prevent assertion crash when editor dialogs are
+ cancelled
+
 2009-04-12 Dan Williams <email address hidden>

  * Tag 0.7.1

 2009-04-04 Dan Williams <email address hidden>

  * Tag 0.7.1-rc4 (0.7.0.100)

=== modified file 'src/connection-editor/nm-connection-list.c'
--- a/src/connection-editor/nm-connection-list.c 2009-04-08 14:16:14 +0000
+++ b/src/connection-editor/nm-connection-list.c 2009-04-15 14:12:47 +0000
@@ -735,16 +735,18 @@ add_done_cb (NMConnectionEditor *editor,
    message = error->message;
   error_dialog (GTK_WINDOW (editor->window),
                 _("Error initializing editor"),
                 "%s", message);
   break;
  case GTK_RESPONSE_OK:
   add_connection (info->list, editor, connection, NULL, NULL);
   break;
+ case GTK_RESPONSE_CANCEL:
+ break;
  default:
   g_assert_not_reached ();
   break;
  }

  g_hash_table_remove (info->list->editors, connection);
 }

[Alexander Sack (asac)]

targetted for SRU.

[Alexander Sack (asac)]

properly indented one is in pastebin: http://paste.ubuntu.com/151479/plain/

[Alexander Sack (asac)]

this was committed upstream. The SRU we plan a week or so after release will pick this fix up from upstream.

[Alexander Sack (asac)]

fixed in karmic