After using scim-pinyin register to im-swith , skim will not start up automatically

[ZhengPeng Hou]

In kubuntu , skim will be disable automatically run , and the config of scim shall be set to use kde panel , then can skim start up using " scim -d " , we can not set that value defautly , so we'd use "skim -d " start skim .

[ZhengPeng Hou (zhengpeng-hou)]

attachment is the debdiff . Add configure to the the conffile in debain/im-switch/scim-pinyin

[Ming Hua (minghua)]

Just a note: with the setting proposed in the patch, im-switch will start skim as long as it's installed, regardless of the X session. In other words, if a user installs both GNOME and KDE (and both scim and skim), this setting will always start skim, even if the user use GNOME.

However if skim works fine in all desktop environments, this is probably not a big deal.

[Ming Hua (minghua)]

You also have typos in the changelog:

s/useing/using/
s/debain/debian/

[ZhengPeng Hou (zhengpeng-hou)]

skim can also work in gnome , and it's UI is more pretty than scim's

[ZhengPeng Hou (zhengpeng-hou)]

correct the spelling error in changelog .

[Ming Hua (minghua)]

The new debdiff still misspell "debian" as "debain".

[ZhengPeng Hou (zhengpeng-hou)]

thanks minghua for pointing out .

[Ming Hua (minghua)]

So generally I am happy with this patch, as it improves the user experience of a default Kubuntu install.

I would like to see some improvement of the coding style, like putting semicolon ";" before space, have the "XIM=..." command in a separate line, not putting the code in changelog, and remove excessive spaces in the last line of changelog. These are all minor points, and personal preference, though. So I'll leave that to the sponsor.

[Ming Hua (minghua)]

On Thu, Mar 23, 2006 at 05:36:11AM -0000, freeflying wrote:
>
> Comment:
> skim can also work in gnome , and it's UI is more pretty than scim's

I've just confirmed that skim indeed works fine in GNOME (the UI is
probably personal preference, but that's not important).

Ming
2006.03.24

[Michael Vogt (mvo)]

Thanks for your patch! I'll sponsor this upload and attach a updated debdiff.

Thanks,
 Michael

[ZhengPeng Hou (zhengpeng-hou)]

also hope other scim module packages like scim-chewing, scim-anthy,scim-tables,scim-hangul can inlude this patch .

[Michael Vogt (mvo)]

This debdiff adresses the points raised earlier. I guess we need to update the other scim modules as well to support skim?