Empty "Personal Package Archives" section shown on person profile pages

[Matthew Paul Thomas]

The profile page for someone who doesn't have a PPA, such as <https://launchpad.net/~gmb> or <https://launchpad.net/~manjo>, contains an empty "Personal package archives" section.

If someone doesn't have a PPA, and they're not you, their page shouldn't have a "Personal package archives" section.

[Michael Nelson (michael.nelson)]

I don't think it will be as trivial as it seems, because currently the PPA section is also used to include a link to a person's private archive subscriptions (if the current user is the profile person) - even if they don't have a PPA themselves...

So either we do: display iff (person has ppa or (current_user is person and person has private archive subscriptions))

OR

we find a better spot for the link for a user to view their own private archive subscriptions and simplify the display of "Personal Package Archives" to simply whether the person has a (public) PPA.

[Julian Edwards (julian-edwards)]

It might be better to explicitly say "This person does not have any PPAs." I find that having major headings contextually appear and disappear is a bit weird.

[Martin Albisetti (beuno)]

I think it would be better to not show anything if that section is going to be empty. That may mean that for *me* there's something, and for other users it's empty.

[Julian Edwards (julian-edwards)]

> So either we do: display iff (person has ppa or (current_user is person and person has private archive subscriptions))

Actually all we need is:

if person has *viewable* ppa OR current_user is person.

We don't need to check for archive subscriptions because they would always need to see "Create a PPA" regardless.

[Julian Edwards (julian-edwards)]

Hit submit too soon.

"current_user is person" should be current user has lp.Edit. This ensures the PPA creation link appears when it should (and hence any subscriptions).

[Diogo Matsubara (matsubara)]

Fixed in devel r8734.

[William Grant (wgrant)]

Really? I still see empty PPA sections in r8750.

[Celso Providelo (cprov)]

On Thu, Jul 2, 2009 at 2:14 AM, William Grant<email address hidden> wrote:
> Really? I still see empty PPA sections in r8750.

Yes, something is wrong.

https://dogfood.launchpad.net/~launchpad-pqm, for instance, which I'm
sure is up-to-date.

Both, the nav-menu entry and the PPA section itself are rendered when
they shouldn't.

--
Celso Providelo <email address hidden>
IRC: cprov, Jabber: <email address hidden>, Skype: cprovidelo
1024D/681B6469 C858 2652 1A6E F6A6 037B B3F7 9FF2 583E 681B 6469

[Julian Edwards (julian-edwards)]

> On Thu, Jul 2, 2009 at 2:14 AM, William Grant<email address hidden> wrote:
> > Really? I still see empty PPA sections in r8750.

William, an example of a page would be more constructive, instead of sniping.

Celso wrote:
> Yes, something is wrong.
>
> https://dogfood.launchpad.net/~launchpad-pqm, for instance, which I'm
> sure is up-to-date.
>
> Both, the nav-menu entry and the PPA section itself are rendered when
> they shouldn't.

I think this is fine in dogfood, it's because we have permission to create a
PPA for it there (we're admins). In lpnet, yeah that's a problem, which is
odd. Thanks for posting an example Celso.

[William Grant (wgrant)]

On Thu, 2009-07-02 at 08:12 +0000, Julian Edwards wrote:
> > On Thu, Jul 2, 2009 at 2:14 AM, William Grant<email address hidden> wrote:
> > > Really? I still see empty PPA sections in r8750.
>
> William, an example of a page would be more constructive, instead of
> sniping.

Sorry, it wasn't intended like that.

I presumed it to be more widespread than it in fact is - I only checked
a few just after I saw the commit. Checking more thoroughly again now,
the fix at least somewhat works. The section seems to have vanished from
most persons. However, gmb and kiko at least have no PPAs (not even a
disabled one), but the empty section is still shown on their pages.

[Julian Edwards (julian-edwards)]

Ok found the bug, it happens when the person is a member of teams that have PPAs.

[Diogo Matsubara (matsubara)]

Fixed in devel r8763.