Merge proposal email rejected, but was still listed as a vote in the UI
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Aaron Bentley |
Bug Description
I sent an email to a merge proposal (two actually; I got the wrong one
the first time). The email was blank, no subject, but had two diffs
attached. In both cases, I got an email back with the message:
Subject: Error Creating Merge Proposal
Your message did not contain a subject. Launchpad code reviews
require all emails to contain subject lines. Please re-send your
email including the subject line.
But in the web UI I can see boxes containing:
Gavin Panella voted 4 minutes ago
But my name is still greyed out in the Reviewer table at the top.
The merge proposals were:
~allenap/
~allenap/
Related branches
- Celso Providelo (community): Approve
- Diff: None lines
Changed in launchpad-bazaar: | |
assignee: | nobody → thumper |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in launchpad-code: | |
status: | Triaged → In Progress |
Changed in launchpad-code: | |
status: | In Progress → Fix Committed |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
Hi Aaron,
This is the bug that I was thinking about for the transaction. commit( ) in the except clause of the JobRunner.