Merge proposal email rejected, but was still listed as a vote in the UI

[Gavin Panella]

I sent an email to a merge proposal (two actually; I got the wrong one
the first time). The email was blank, no subject, but had two diffs
attached. In both cases, I got an email back with the message:

  Subject: Error Creating Merge Proposal

  Your message did not contain a subject. Launchpad code reviews
  require all emails to contain subject lines. Please re-send your
  email including the subject line.

But in the web UI I can see boxes containing:

  Gavin Panella voted 4 minutes ago

But my name is still greyed out in the Reviewer table at the top.

The merge proposals were:

  ~allenap/launchpad/rala-bugwatch-bug-345447/+merge/5191
  ~allenap/launchpad/rala-assignee-bug-354431/+merge/5198

[Tim Penhey (thumper)]

Hi Aaron,

This is the bug that I was thinking about for the transaction.commit() in the except clause of the JobRunner.

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Tim Penhey wrote:
> This is the bug that I was thinking about for the transaction.commit()
> in the except clause of the JobRunner.

Changing it to transaction.abort seems like a positive step, but this
might also be a case where the job itself is committing the transaction
early, to appease the Librarian.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpnDm4ACgkQ0F+nu1YWqI1B7ACfQfpO2joZvN7HF+3LE1J8l5yk
DnkAn1sNobS41JjwTlN84aFIvZ6y7VEA
=iWtA
-----END PGP SIGNATURE-----

[Aaron Bentley (abentley)]

Actually, the JobRunner issues are completely separate, because vote processing is done only by incoming mail CodeHandler.

[Matthew Revell (matthew.revell)]

Retargeting to 3.0, which is the new name for 2.2.9. Haven't renamed the milestone as the 3.0 milestone is in a different series.