Launchpad itself

c.l.d.Distribution.getPackageNames appears to be an unused/untested code path

Bug #3530 reported by Brad Bollenbach on 2005-10-24

Affects		Status	Importance	Assigned to	Milestone
	Launchpad itself	Fix Released	Medium	Unassigned

Bug Description

make lintmerge reports the following for me, related to c.l.d.Distribution.getPackageNames:

...
E0602:451:Distribution.getPackageNames: Undefined variable 'SourcePackagePublishing'
E0602:470:Distribution.getPackageNames: Undefined variable 'PublishedPackage'
...

These are missing imports.

This almost surely means this is an unused/untested code path. Either the code should be ditched, or it should be tested and made sure it's actually being used in the application.

Tags:

Revision history for this message

James Henstridge (jamesh) wrote on 2005-10-25:

I have a fix for this in my launchpad--bugzilla-import--0 branch, which also adds some tests that indirectly exercise the code.

Revision history for this message

Dafydd Harries (daf) wrote on 2005-12-16:

James: has the branch you mentioned been landed?

Changed in launchpad:
status:	New → Accepted

Celso Providelo (cprov) on 2005-12-19

Changed in launchpad:
status:	Accepted → Fixed

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.