online_help returns false information

Bug #350465 reported by Fake Name
28
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Widelands Website
Fix Released
Medium
GunChleoc
widelands
Fix Released
Undecided
GunChleoc

Bug Description

For example look at http://wl.widelands.org/help/barbarians/buildings/ (or any other help page for buildings)
Hunter's hut requires 4 trunks and 1 raw stone not 1 trunk and 4 raw stones. This applies to all other buildings that require more than 2 different wares (except for those, where number of wares is the same for all). This gives quite much misleading information.

Tags: help

Related branches

Revision history for this message
Sigra (sigra) wrote :

Why not generate online help directly from widelands and put it online? It generates correct information, has crossreferences and supports every language that Widelands is translated to.

Revision history for this message
Fake Name (fakeuserxxxx-deactivatedaccount) wrote :

The information is generated form widelands. And if you meant using the html files generated by widelands, hmm...

Revision history for this message
Sigra (sigra) wrote :

I meant xhtml files generated by the widelands executable.

Revision history for this message
SirVer (sirver) wrote :

Sigra, how much work would it be to generate this information without graphic startup and so on? I personally would prefer the way generated html from conf files -> website -> static html files in releases (instead of widelands generated html files -> homepage). The simple reason is that I think widelands is feature bloated and should be made smaller and more modular instead of more powerfull. Pro for your approach is obviously that it is already implemented on one side.

Revision history for this message
Sigra (sigra) wrote :

It would be possible to make a separate executable for generating xhtml. Then the code in writeHTML.o does not have to bloat the widelands executable. Of course the code in tribe.o, world.o, profile.o (and maybe some more units) has to be in both executables (so the total bloat would be bigger unless the executables load a shared object).

When building a release package, the xhtml generator must be executed for each language that should be included in the release. The generated files must be installed together with the game data.

When a source-based distribution builds a package and installs it, the xhtml generator must be executed for the languages that the user has configured his system to support (the LINGUAS variable in /etc/make.conf in Gentoo).

If someone takes care of the Scons part of creating a separate executable, I could try to make the C++ part work.

SirVer (sirver)
Changed in widelands-website:
importance: Undecided → High
status: New → Confirmed
janus (janus-jhor)
Changed in widelands-website:
status: Confirmed → In Progress
Revision history for this message
Tino (tino79) wrote :

Another wrong info:
All descriptions of the three tribes wells show "Carries items along your roads."

kaputtnik (franku)
tags: added: encyclopedia
Revision history for this message
kaputtnik (franku) wrote :

I changed importance to medium, because we may generate the encyclopedia from json files. If we do so, there has to be made a json-export function in widelands itself.

Changed in widelands-website:
importance: High → Medium
status: In Progress → Confirmed
Revision history for this message
GunChleoc (gunchleoc) wrote :

Since the import will stop working altogether when I merge one tribe this weekend, maybe we should remove this from the website and add a note to steer the users to the in-game help for now.

I have just sent a merge request for the game with improved help for the wares.

GunChleoc (gunchleoc)
Changed in widelands-website:
assignee: nobody → GunChleoc (gunchleoc)
status: Confirmed → In Progress
GunChleoc (gunchleoc)
Changed in widelands:
status: New → In Progress
assignee: nobody → GunChleoc (gunchleoc)
milestone: none → build19-rc1
Revision history for this message
kaputtnik (franku) wrote :

The executable wl_map_object_info doesn't work on the server (missing x-server). See https://code.launchpad.net/~widelands-dev/widelands-website/encyclopedia/+merge/287410/comments/758320

GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
Changed in widelands-website:
status: In Progress → Fix Released
Revision history for this message
SirVer (sirver) wrote :

You are so awesome!!! Thanks for fixing this!

Revision history for this message
GunChleoc (gunchleoc) wrote :

Especially thanks to Kaputtnik who did the less interesting part of the job!

Revision history for this message
kaputtnik (franku) wrote :

This is IMHO not finally fixed... unless we find a solution for the "display" thing. That's why i proposed another branch. I want to have a real fix because this needs also implemented in the django1_8 branch and i don't want to do multiple merges.

The job was maybe less interesting but i have a great respect when working on the server and it's very exciting.

Revision history for this message
SirVer (sirver) wrote :

I changed the automatic updating of the help on the server (see /etc/cron.daily/django_regular_commands) and it ran through for me twice now. So automatic updating should now work.

GunChleoc (gunchleoc)
tags: added: help
removed: encyclopedia
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.