syntax error in vzmigrate script (line 382)

[Guido Nickels]

Binary package hint: vzctl

Hi!

When trying to do an online migration, the vzmigrate script throws the following error: "[: 386: missing ]"

Reason: In line 382 of /usr/sbin/vzmigrate script, you will find the following code:

if [ $? != 20 && $? != 21 && $? != 0 ]; then

This is not working because test doesn't accept "&&".

Fix:

if [ $? != 20 -a $? != 21 -a $? != 0 ]; then

or:

if [ $? != 20 ] && [ $? != 21 ] && [ $? != 0 ]; then

As this seems to break online migration completely, I consider it quite important to be fixed.

Regards,

Guido

[Daniel Hahler (blueyed)]

This is fixed in vzctl 3.0.22-14ubuntu2 (in Jaunty) already, which uses:
  if [ $? != 20 ] && [ $? != 21 ] && [ $? != 0 ]; then

Thanks for reporting this bug anyway!