ZStorm code should warn or error out on attempts to register a store with the transaction manager in the wrong thread

[James Henstridge]

Today I was helping debug a problem in a multi-threaded app that uses the zstorm code to manage per-thread stores.

There was a bug in the code where a Storm object was passed from thread A to thread B to another. When the object was used, the associated store was registered with the transaction manager in thread B. The transaction in thread B was not committed.

When the program attempted to run the next transaction in thread A, it'd start using the same store which was already in an open transaction. Furthermore, because the store had been registered with thread B's transaction, committing in thread A doesn't commit the store.

If register_store_with_transaction() raised an error if the store passed in did not belong to the current thread, then the bug would have been immediately obvious and taken much less time to debug.

This seems like an API misuse that is worthwhile trying to detect.

[James Henstridge (jamesh)]

Fix merged in r359.