Replying to a diff in a merge proposal comment totally misquotes it

[Christian Reis]

I was pretty surprised to click on reply when looking at Celso's MP diff here:

  https://code.edge.launchpad.net/~cprov/launchpad/bug-326091-package-index-bugs-field/+merge/4736

and get back a completely garbled quoted diff. I think there's something bad in the handling of comment text which is leading to this.

I am going to piggyback here and ask why it is that when clicking on "review" I don't get the diff quoted. I think having separate "review" and "comment" forms may be a disservice to us; we could just simplify this and have a comment form which allowed you to add a review as part of the review if you had the relevant privs.

[Tim Penhey (thumper)]

On Sun, 22 Mar 2009 01:22:53 Christian Reis wrote:
> Public bug reported:
>
> I was pretty surprised to click on reply when looking at Celso's MP diff
> here:
>
> https://code.edge.launchpad.net/~cprov/launchpad/bug-326091-package-
> index-bugs-field/+merge/4736
>
> and get back a completely garbled quoted diff. I think there's something
> bad in the handling of comment text which is leading to this.

There is something seriously wrong here.

> I am going to piggyback here and ask why it is that when clicking on
> "review" I don't get the diff quoted. I think having separate "review"
> and "comment" forms may be a disservice to us; we could just simplify
> this and have a comment form which allowed you to add a review as part
> of the review if you had the relevant privs.

Yes, I agree with you here. I've been talking to beuno about this again, and
I think that we don't want separate views.

[Tim Penhey (thumper)]

On Sun, 22 Mar 2009 10:59:27 Tim Penhey wrote:
> On Sun, 22 Mar 2009 01:22:53 Christian Reis wrote:
> > Public bug reported:
> >
> > I was pretty surprised to click on reply when looking at Celso's MP diff
> > here:
> >
> > https://code.edge.launchpad.net/~cprov/launchpad/bug-326091-package-
> > index-bugs-field/+merge/4736
> >
> > and get back a completely garbled quoted diff. I think there's something
> > bad in the handling of comment text which is leading to this.
>
> There is something seriously wrong here.

Just a stab in the dark,but I'm guessing we are missing a "structure"
somewhere.