HMTL value is unquoted when HTML attribute is target

Bug #346203 reported by Malcolm Fitzgerald
4
Affects Status Importance Assigned to Milestone
Woda
Fix Released
Low
Xavier Brochard
4.610
Fix Released
Low
Xavier Brochard

Bug Description

WODA 4.603 (woda/mf branch rev.23)
PERL 5.8.8

Unquoted values for HTML attributes occur in many places. This list is only for the target attribute.

subroutine: cgiSearch
code is: TARGET=woda_basket
should be: target="woda_basket"

subroutine: setShowToolbar.
code is: $target = "TARGET=_self";
should be: $target = 'target="_self"';

subroutine: setShowToolbar
code is: $target = 'TARGET=woda_basket';
should be: $target = 'target="woda_basket"';

subroutine: printBasket
code is: $TargetDefault = "TARGET=woda_opener";
should be: $TargetDefault = 'target="woda_opener"';

subroutine: cgiLogin
code is: <br><a href="$hr" target=woda_opener>$hr</a>.
should be: <br><a href="$hr" target="woda_opener">$hr</a>.

subroutine: printRecords
code is: <form action="$SCRIPT/BasketEdit" target=_self>
should be: <form action="$SCRIPT/BasketEdit" target="_self">

subroutine: cgiAdmModifySettingMenu
code is: <a href="$SCRIPT/Home" target=_parent><img src="$ICONURL/home.gif" $ICONPAR title="Main Menu" alt="Main Menu"></a>
<a href="$SCRIPT/AdmMenu" target=_parent><img src="$ICONURL/ahome.gif" $ICONPAR alt="Admin Menu" title="Admin Menu"></a>
should be: <a href="$SCRIPT/Home" target="_parent"><img src="$ICONURL/home.gif" $ICONPAR title="Main Menu" alt="Main Menu"></a>
<a href="$SCRIPT/AdmMenu" target="_parent"><img src="$ICONURL/ahome.gif" $ICONPAR alt="Admin Menu" title="Admin Menu"></a>

subroutine: cgiAdmModifySettingF
code is: print qq(<br><a href="$SCRIPT/AdmModifySettingToFrameX?type=f&amp;name=$f" target=woda_right>$f</a>\n);
should be: print qq(<br><a href="$SCRIPT/AdmModifySettingToFrameX?type=f&amp;name=$f" target="woda_right">$f</a>\n);

Related branches

Xavier Brochard (xavier)
Changed in woda:
importance: Undecided → Low
milestone: none → merge-mf-and-xavier
status: New → Confirmed
Xavier Brochard (xavier)
Changed in woda:
assignee: nobody → Xavier Brochard (xavier)
status: Confirmed → Won't Fix
status: Won't Fix → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.