Drop gray background in the column used for sorting

[Raphaël Hertzog]

The gray background in the column used for sorting is in direct conflict with the colors coming from tags. The result is not nice and makes it difficult to identify task accurately.

In particular I use the gray color for a tag that I called status:inactive so, when I sort by title most of the lines end up gray even those that are not inactive !!

[IC Raibow (icrbow)]

Just don't change color for tag column if there any colored tags.

[Lionel Dricot (ploum-deactivatedaccount)]

wiz > I don't understand your suggestion.

[Lionel Dricot (ploum-deactivatedaccount)]

I defer this bug to 0.2 because it's not critical and nor Bertrand nor me has any idea on how to achieve this. We spent some hours on this without success.

[Antons Rebguns (arebgun)]

Could you post a screenshot to make it painfully clear for me :) ? No matter what color I choose for a tag it's still very clearly identifiable. Maybe it's theme dependent?

[Diogo Ferreira (diogo-underdev)]

I have a suggestion on how to solve this but I'm not sure if it's doable.

When picking the color for backgrounds with tags (GTG/taskbrowser/tasktree.py:111-114) if the result color is None or if bg_color_enable is False, then the background color is set to the default cell render color.

There is a slight problem though, this default cell color can only be obtained after receiving map-event.

[Michael Budde (mbudde)]

I've taken a screenshot of what I think Raphael is describing. If this is not the case, then I'm sorry! :)

[Paul Natsuo Kishimoto (khaeru)]

Something relevant: http://www.pygtk.org/docs/pygtk/class-gtktreeview.html#method-gtktreeview--set-rules-hint

In Michael's screenshot, the sort column has alternating colours for the cells in the last three rows, where the cell colour is not set explicitly. If the rules-hint was set to False, then *some* themes *might* not use alternating colours.

...anyway, I don't think this is what Raphael is asking for. To not highlight the sort column is not a built-in feature of gtk.TreeView. Two options would be:

1. Extend the cell renderer used in the task tree to check whether the cell being rendered is in the sort column. If it is, and if the task on that row has no colour, take some step to change the cell-background colour in that cell.
2. Choose (I don't know how) a cell-background to use for tasks that have no colour, and *always* use a cell-background.

I don't like the second option, because it means that users who choose not to use many coloured tags will not have the benefit of the built-in GTK alternating-rows colouring.

The first option seems like a lot of work, but I guess it is possible.

There are some other bugs related to major changes in the taskbrowser, like bug #340022 (group by due date)...maybe it would be better to tackle that first and then see if this is still a concern.

[Bertrand Rousseau (bertrand-rousseau)]

I agree about th epriority of this bug. And we should also check the GNOME HIG for that. If it's an accessibility issue, then it's also worth doing it. A better solution is maybe to adopt a the color generated from the tags, but applying a filter that darkens it for the sorting color, so the "highlitgh sorting column" behavior is kept coherent.

[Lionel Dricot (ploum-deactivatedaccount)]

Izidor > I saw your fix, please push it to the trunk :-)

[Izidor Matušov (izidor)]

This is solved for Tags pane. I am not sure about the active task pane. I thing it was successfully solved in 0.2.4 => closing this bug as Fixed Committed.