subscribing a search without value
Bug #342973 reported by
Xavier Brochard
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Woda |
Fix Released
|
Low
|
Malcolm Fitzgerald | ||
4.610 |
Fix Released
|
Low
|
Malcolm Fitzgerald |
Bug Description
in search results (cgiSearch), icon for subscribing a search ("I want to subscribe to searches like this.")
may call AgentAddForm without value for $Formdata parameter - try with What's new (cgiNewForm) for instance.
$Formdata is set in sub saveFormToolbar (but it returns another icon)
and the first line of cgiSearch, call sub saveFormToolbar
It was called 2 times before because cgiSearch reset toolbar:
# undef @Toolbar; # zakaj? subforma?
# do saveFormToolbar(); # search filed gets spoiled!
Woda 4.603, Perl 5.8 and Perl 5.10
Related branches
lp:~malcolm-notyourhomework/woda/mf
(Merged)
Changed in woda: | |
importance: | Undecided → Low |
Changed in woda: | |
assignee: | nobody → malcolm-notyourhomework |
status: | New → Confirmed |
status: | Confirmed → Fix Committed |
Changed in woda: | |
milestone: | none → merge-mf-and-xavier |
Changed in woda: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This can be fixed with this code:
At the very end of cgiSearch look for "I want to subscribe to searches like this."
Add the two lines beginning with $Formdata. The block should look like this:
if (&wbAllowed( $Group, 'AgentAddForm' ) && ! $agentFile) {
$text = "I want to subscribe to searches like this."; #UK
$Formdata = &hashExport(*CGI);
$Formdata = &htEscape($x);
push (@Toolbar,<<EOM); SCRIPT/ AgentAddForm? FORM=AgentAddFo rm& formdata= $Formdata" $TargetParent> angie.gif" alt="$text" title="$text"></a>
<a href="$
<img $ICONPAR src="$ICONURL/
EOM
}