wrong version number in automatic update alert

Bug #341643 reported by Stefan Neumärker
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Sparkle
Status tracked in 1.5
1.5
Fix Committed
Critical
Unassigned

Bug Description

Automatic update alert shows wrong version number (number of installed, not downloaded version).

Replace this

- (NSString *)descriptionText
{
 return [NSString stringWithFormat:SULocalizedString(@"%1$@ %2$@ has been downloaded and is ready to use! Would you like to install it and relaunch %1$@ now?", nil), [host name], [host displayVersion]];
}

by this

- (NSString *)descriptionText
{
 return [NSString stringWithFormat:SULocalizedString(@"%1$@ %2$@ has been downloaded and is ready to use! Would you like to install it and relaunch %1$@ now?", nil), [host name], [updateItem displayVersionString]];
}

Revision history for this message
Jim Turner (myztikjenz) wrote :

We just had three complains about this all within about five minutes of each other... not a single mention previous. Very odd. Attached a patch file that's the same change Stefan provided in his comments.

Revision history for this message
Andy Matuschak (andymatuschak) wrote :

How the heck did this go unnoticed for so long?

Changed in sparkle:
status: New → Confirmed
importance: Undecided → Critical
milestone: none → 1.5
Revision history for this message
Andy Matuschak (andymatuschak) wrote :

Thanks for the patch! Landed in 1dd1b09.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.