Strip leading and trailing whitespace before storing a bug watch's remotebug in the db

[Björn Tillenius]

If someone, by accident, includes leading or trailing whitespace when inputting the remote bug of a bug watch, for example when copy and pasting, we preserve the whitespace when storing it in the database.

This can cause subtle problems, and there's no use case for preserving the whitespace. We should strip the whitespace before storing the remote bug in the database.

[Björn Tillenius (bjornt)]

Matsubara, maybe you could have a look at this?

[Christian Reis (kiko)]

Interesting issue. It happens because we are storing remotebug as a text field instead of as an ID; this makes us more flexible but it requires more careful processing of the field.

Here are some other questions relating to the use of the text type in the DB:

- Do we strip whitespace when a user enters a value for a "name" field?
- Do we strip whitespace when a user enters a value for an email address?
- Do we strip whitespace when a user enters a wikiname or a wiki url? What about jabberid? What about irc network and nick?
- What about a product's releaseroot, or a productseries' cvs, svn or bk details?

Perhaps it makes sense to have something like a StrippedAttribute or StrippedTextLine or StrippedURL field in the interfaces?

[Björn Tillenius (bjornt)]

Yes, I think StrippedTextLine makes sense. It'd be useful for more than just remote bug ids.

One question that comes to mind, though, do we ever want to preserve leading and trailing whitespace for single line input? It might be easier to simply override the default widget for text lines to always strip the leading and trailing whitespace.

Having something like StrippedTextLine would be more correct, though.

[David Allouche (ddaa)]

Agreed, and mpt agrees too: me should strip whitespace in all single-line text fields. Filed bug 44197 and assigned to matsubara with kiko's permission.