"Change details" for POTemplate should allow maintainers some more freedom
Bug #340662 reported by
Данило Шеган
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Adi Roiban |
Bug Description
At the moment, "change details" link on POTemplates has very limited options.
We should move at least translation domain, path and "accept translations" from "Admin" to "Change details" form.
Related branches
lp:~adiroiban/launchpad/bug-340662
Merged
into
lp:launchpad
- Данило Шеган (community): Disapprove
- Eleanor Berger (community): Approve
-
Diff: 222 lines (+63/-24)6 files modifiedlib/canonical/launchpad/security.py (+26/-1)
lib/lp/translations/browser/potemplate.py (+3/-2)
lib/lp/translations/configure.zcml (+8/-2)
lib/lp/translations/stories/productseries/xx-productseries-templates.txt (+21/-8)
lib/lp/translations/stories/standalone/xx-potemplate-edit.txt (+4/-10)
lib/lp/translations/templates/object-templates.pt (+1/-1)
lp:~adiroiban/launchpad/bug-340662-take-2
- Brad Crittenden (community): Approve (code)
-
Diff: 275 lines (+72/-52)5 files modifiedlib/canonical/launchpad/security.py (+3/-28)
lib/lp/translations/browser/configure.zcml (+2/-2)
lib/lp/translations/browser/potemplate.py (+9/-8)
lib/lp/translations/configure.zcml (+2/-2)
lib/lp/translations/stories/standalone/xx-potemplate-edit.txt (+56/-12)
Changed in rosetta: | |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in rosetta: | |
status: | In Progress → Fix Committed |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-needstesting removed: qa-bad |
Changed in rosetta: | |
milestone: | none → 10.01 |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in rosetta: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Since domain name is somehow linked to template name, I have also added „template name” in the Edit view.
Since „accept translations” can be modified, the launchpad.Edit should be allowed for disabled templates.