code review comment font is too big

Bug #340275 reported by Martin Pool
10
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Tim Penhey

Bug Description

The monospace comment font is larger than the comment font used for eg bugs, and roughly twice as big as the font used for the headers like "Status". As a result if your base font is set to a reasonable size, the comment font looks far too big. (jml correctly observes that you can work around this by scaling the page so the other fonts are too small. :-)

It should be the same font across launchpad.

Revision history for this message
Martin Pool (mbp) wrote :

merge proposal screenshot

Revision history for this message
Martin Pool (mbp) wrote :

bug screenshot

Paul Hummer (rockstar)
Changed in launchpad-bazaar:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Julian Edwards (julian-edwards) wrote :

After mpt duped my bug 344769 to this one, is this a Konqueror problem only?

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Well, it might be worse currently in Konqueror than in other browsers because Konqueror's default font settings are different. But if code review comments become styled in exactly the same way as bug comments (i.e. using the same rule in the style sheet as bug comments do), then it will be just as fixed in Konqueror as it is in other browsers.

Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 340275] Re: code review comment font is too big

2009/3/19 Matthew Paul Thomas <email address hidden>:
> Well, it might be worse currently in Konqueror than in other browsers
> because Konqueror's default font settings are different. But if code
> review comments become styled in exactly the same way as bug comments
> (i.e. using the same rule in the style sheet as bug comments do), then
> it will be just as fixed in Konqueror as it is in other browsers.

I'm pretty sure they are not styled the same as bug comments, because
I can reproduce this in a plain firefox install. (I haven't traced
through the html/css to work out just why.) That's the bug. It's not
browser specific.

--
Martin <http://launchpad.net/~mbp/>

Revision history for this message
Tim Penhey (thumper) wrote :

Found it.

Changed in launchpad-code:
assignee: nobody → Tim Penhey (thumper)
milestone: none → 2.2.6
status: Triaged → In Progress
Revision history for this message
Tim Penhey (thumper) wrote :

Missed the RC cut off.

Changed in launchpad-code:
milestone: 2.2.6 → 2.2.7
Revision history for this message
Tim Penhey (thumper) wrote :

Fixed in RF 8712.

Changed in launchpad-code:
status: In Progress → Fix Committed
Revision history for this message
Martin Pool (mbp) wrote :

Reopening: it's fixed in the main code review page but not in the "reply" page, eg https://code.edge.launchpad.net/~mbp/bzr/340347-log-decorator/+merge/8075/comments/20848/+reply

Changed in launchpad-code:
status: Fix Committed → Confirmed
Revision history for this message
Tim Penhey (thumper) wrote :

Pushing off to 2.2.8 for the comment page itself.

Changed in launchpad-code:
milestone: 2.2.7 → 2.2.8
status: Confirmed → Triaged
Tim Penhey (thumper)
Changed in launchpad-code:
status: Triaged → In Progress
Revision history for this message
Tim Penhey (thumper) wrote :

Fixed in RF 8986.

Changed in launchpad-code:
status: In Progress → Fix Committed
Tim Penhey (thumper)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.