Morse misses the last .

Bug #339514 reported by Stefano Rivera
2
Affects Status Importance Assigned to Milestone
Ibid
Fix Released
Medium
Stefano Rivera

Bug Description

Because Strip removes trailing .s, morse doesn't get to see them.

Changing morse' priority doesn't work, as Event depends on a 'message_raw' being created.

This one needs some thought.

Changed in ibid:
importance: Undecided → Medium
milestone: none → 0.1
Revision history for this message
Jonathan Hitchcock (vhata) wrote :

Knab's Strip module adds an extra element to the query called "unstripped" - modules which need to access the raw stuff that the user actually typed can examine 'unstripped', and modules which need sanitised queries access the stripped one.

Ibid could do the same, but it means that plugins become a little more interdependent and less standalone. However, I can't see any other way of allowing Strip to sanitise input for some plugins and not for others.

Revision history for this message
Stefano Rivera (stefanor) wrote : Re: [Bug 339514] Re: Morse misses the last .

> Knab's Strip module adds an extra element to the query called
> "unstripped" - modules which need to access the raw stuff that the user
> actually typed can examine 'unstripped', and modules which need
> sanitised queries access the stripped one.

Ibid does the same thing - there is something called raw_message. However that
on its own is not enough, as "morse ." won't match the current morse pattern.

SR

Revision history for this message
Michael Gorven (mgorven) wrote :

Ibid already has a raw_message attribute containing the original message. This
includes addressing though. Are you suggesting an attribute with the
addressing removed but otherwise not modified?

Revision history for this message
Stefano Rivera (stefanor) wrote :

no, I'm saying that morse never gets called, if you say "bot: morse .", so it can't even go poking in raw_message and see what's there.

Changed in ibid:
assignee: nobody → stefanor
status: New → In Progress
Changed in ibid:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.