UnicodeWarning: Unicode unequal comparison failed causes failure in test_unicode_symlink

[Bob Tanner]

ERROR: test_unicode_symlink (bzrlib.tests.workingtree_implementations.test_parents.TestSetParents)

vvvv[log from bzrlib.tests.workingtree_implementations.test_parents.TestSetParents.test_unicode_symlink(WorkingTreeFormat5)]
2727.629 creating repository in file:///tmp/testbzr-zOsa5y.tmp/bzrlib.tests.workingtree_implementations.test_parents.TestSetParents.test_unicode_symlink%28WorkingTreeFormat5%29/work/tree1/.bzr/.
2727.637 creating branch <bzrlib.branch.BzrBranchFormat6 object at 0x9e18dec> in file:///tmp/testbzr-zOsa5y.tmp/bzrlib.tests.workingtree_implementations.test_parents.TestSetParents.test_unicode_symlink%28WorkingTreeFormat5%29/work/tree1/.bzr/
2727.646 trying to create missing lock '/tmp/testbzr-zOsa5y.tmp/bzrlib.tests.workingtree_implementations.test_parents.TestSetParents.test_unicode_symlink(WorkingTreeFormat5)/work/tree1/.bzr/checkout/dirstate'
2727.647 opening working tree '/tmp/testbzr-zOsa5y.tmp/bzrlib.tests.workingtree_implementations.test_parents.TestSetParents.test_unicode_symlink(WorkingTreeFormat5)/work/tree1'
2727.677 preparing to commit
    INFO Committing to: /tmp/testbzr-zOsa5y.tmp/bzrlib.tests.workingtree_implementations.test_parents.TestSetParents.test_unicode_symlink(WorkingTreeFormat5)/work/tree1/
2727.687 Selecting files for commit with filter []
    INFO added link_name
    INFO Committed revision 1.
2727.710 preparing to commit
    INFO Committing to: /tmp/testbzr-zOsa5y.tmp/bzrlib.tests.workingtree_implementations.test_parents.TestSetParents.test_unicode_symlink(WorkingTreeFormat5)/work/tree1/
2727.713 Selecting files for commit with filter []
2727.714 aborting commit write group because of exception:
2727.715 Traceback (most recent call last):
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/commit.py", line 367, in commit
    self._update_builder_with_changes()
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/commit.py", line 667, in _update_builder_with_changes
    self._populate_from_inventory()
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/commit.py", line 814, in _populate_from_inventory
    content_summary)
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/commit.py", line 858, in _record_entry
    ie, self.parent_invs, path, self.work_tree, content_summary)
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/repository.py", line 475, in record_entry_contents
    if current_link_target != parent_entry.symlink_target:
  File "/home/tanner/lib/python2.5/warnings.py", line 62, in warn
    globals)
  File "/home/tanner/lib/python2.5/warnings.py", line 102, in warn_explicit
    raise message
UnicodeWarning: Unicode unequal comparison failed to convert both arguments to Unicode - interpreting them as being unequal

    INFO aborting commit write group: UnicodeWarning('Unicode unequal comparison failed to convert both arguments to Unicode - interpreting them as being unequal',)
2727.732 opening working tree '/tmp/testbzr-zOsa5y.tmp'

^^^^[log from bzrlib.tests.workingtree_implementations.test_parents.TestSetParents.test_unicode_symlink(WorkingTreeFormat5)]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/tests/workingtree_implementations/test_parents.py", line 252, in test_unicode_symlink
    revision2 = tree.commit('this revision will be discarded')
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/decorators.py", line 192, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/workingtree_4.py", line 226, in commit
    result = WorkingTree3.commit(self, message, revprops, *args, **kwargs)
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/decorators.py", line 192, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/mutabletree.py", line 228, in commit
    *args, **kwargs)
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/commit.py", line 367, in commit
    self._update_builder_with_changes()
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/commit.py", line 667, in _update_builder_with_changes
    self._populate_from_inventory()
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/commit.py", line 814, in _populate_from_inventory
    content_summary)
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/commit.py", line 858, in _record_entry
    ie, self.parent_invs, path, self.work_tree, content_summary)
  File "/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1/bzrlib/repository.py", line 475, in record_entry_contents
    if current_link_target != parent_entry.symlink_target:
  File "/home/tanner/lib/python2.5/warnings.py", line 62, in warn
    globals)
  File "/home/tanner/lib/python2.5/warnings.py", line 102, in warn_explicit
    raise message
UnicodeWarning: Unicode unequal comparison failed to convert both arguments to Unicode - interpreting them as being unequal

----------------------------------------------------------------------
Ran 15652 tests in 2710.358s

FAILED (errors=1, known_failure_count=19)
1334 tests skipped
Missing feature 'FTPServer' skipped 79 tests.
Missing feature 'Internally performed glob expansion' skipped 5 tests.
Missing feature '_winreg' skipped 2 tests.
Missing feature 'attrib Windows command-line tool' skipped 1 tests.
Missing feature 'bzrlib._Win32ReadDir' skipped 11 tests.
Missing feature 'bzrlib._btree_serializer_c' skipped 1 tests.
Missing feature 'bzrlib._chunks_to_lines_pyx' skipped 1 tests.
Missing feature 'bzrlib._dirstate_helpers_c' skipped 97 tests.
Missing feature 'bzrlib._knit_load_data_c' skipped 27 tests.
Missing feature 'bzrlib._readdir_pyx' skipped 3 tests.
Missing feature 'case-insensitive case-preserving filesystem' skipped 20 tests.
Missing feature 'case-insensitive filesystem' skipped 1 tests.
Missing feature 'win32com.shell' skipped 4 tests.
tests failed
bzrlib.tests.blackbox.test_branch.TestBranchStacked.test_branch_stacked_from_smart_server is leaking threads among 1706 leaking tests
make[1]: *** [check-nodocs] Error 1
make[1]: Leaving directory `/tmp/tmp_bzr_check_dist.anJbR10138/bzr-1.13rc1'
make: *** [check-dist-tarball] Error 2

[Martin Pool (mbp)]

@tanner reports that this is blocking release of 1.13rc1 because it happens during make check-dist-tarball.

[Daniel Clemente (n142857)]

The failing test is for bug #272444. The test itself could be improved (see message from right now in mailing list), or the bug fixed (there's a patch).