Right-click actions should be able to operate on multiple transactions

Bug #338890 reported by Michael Rooney
4
Affects Status Importance Assigned to Milestone
wxBanker
Fix Released
Low
Michael Rooney

Bug Description

If you select multiple transactions and right-click, those operations should work on those transactions, so you can remove multiple transactions or add/subtract multiple transactions to the calculator.

Revision history for this message
Michael Rooney (mrooney) wrote :

I'll merge in Karel's work on this!

Changed in wxbanker:
assignee: nobody → mrooney
importance: Undecided → Low
milestone: none → 0.5
status: New → Triaged
Revision history for this message
Michael Rooney (mrooney) wrote :

I also pushed this, with a modification. If there is just one transaction, it will still say "Remove this transaction", otherwise it says the number such as "Remove these 3 transactions". I think that will make it clearer to the user and make sure what they are intending to do is actually what they are triggering.

Thanks again, I have wanted to do this a time or do before!

I merged in your changes for the calculator and this as rev 170, then made my modifications as 171, so if you want to look at a diff between those (http://bazaar.launchpad.net/~mrooney/wxbanker/wxbanker-olv/revision/171) and let me know if that I kept the general theme of your intentions, that would be awesome!

Changed in wxbanker:
status: Triaged → Fix Committed
Revision history for this message
Karel Kolman (kolmis) wrote :

thanks for merging, i agree with your changes to my ugly code.

i initially had the code that used the total value from the clicked row and passed it down.

i think onCalculatorAction should be changed to receive the amount (the sum or the total) as an argument instead of the transaction list and the column.

i commited one more line change to fix the right-click to also set focus to the clicked row (i realized the right click behavior is coded in the mixin wx.lib.mixins.listctrl.ListCtrlSelectionManagerMix, but since it's a one line code addition using ObjectListView methods, it's not worth using)

Revision history for this message
Michael Rooney (mrooney) wrote :

Released in 0.5!

Changed in wxbanker:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.