GTG

Allow the user to suppress a task in the task list with the suppr key

Bug #336314 reported by antistress
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GTG
Fix Released
Low
Unassigned

Bug Description

it would be cool to be able to suppress (or dismiss ?) a task from the task list by pressing the suppr key

Changed in gtg:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Gérôme Fournier (jefke) wrote :

Here goes a patch to handle deletion of tasks using the "Delete" key.
Code re-factory might be required, if you don't like the self.on_delete_task(None) call.
(i.e a common method to delete a task, called by both on_delete_task and on_task_treeview_key_press_event)

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Patch committed in rev.186.

I've changed the None because it's not very pretty but, besides that, it was perfect !
Thanks a lot for your work :-)

Changed in gtg:
assignee: nobody → ploum
milestone: none → 0.2
status: Confirmed → Fix Committed
Revision history for this message
antistress (antistress) wrote :

So did you choose suppress or dismiss for the del key ?

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Well, I forgot to think so, currently, the delete key choose the delete action (suppress). I think it looks more logical and intuitive. Also, it popup a confirmation dialog so even if you press the key by mistake, you understand what's happening.

But I don't have a solid opinion on this and it could be changed at any time, nothing is engraved in stone.

Revision history for this message
Gérôme Fournier (jefke) wrote :

Fine, so here goes the same one for the taskdone_tview TreeView.

Revision history for this message
Gérôme Fournier (jefke) wrote :

"Delete" for deletion sounds relevant, maybe "D" key for dismiss, and "U" for undismiss for the taskdone_tview TreeView?

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

(thanks for the patch, I will apply this right now)

Regarding the D and U, I'm not sure it's a good idea because it's not i18n friendly

Changed in gtg:
milestone: 0.2 → 0.1.1
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Patches

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.