Validate IProduct.sourceforgeproject, and apply retrospective data fix

Bug #334288 reported by Gavin Panella
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Gavin Panella

Bug Description

Changes to IProduct.sourceforgeproject are subject to minimal
validation, little enough that a lot of the data we have is invalid. A
lot of the time we see that sourceforgeproject is a full URL, and
sometimes it's not even ASCII.

In fact, SourceForge requires that project names conform to RFC 1035,
section 2.3.1. I believe that the definition of <label> in that
section is what we're looking for.

A basic validation method, valid_sourceforge_product_name, is being
added to canonical/launchpad/scripts/sfremoteproductfinder.py. This,
afaict, implements a reliable check for <label>. This function should
be changed into a validator and used to validate changes to
IProduct.sourceforgeproject.

Additionally, we should apply a retrospective data fix. See
SourceForgeRemoteProductFinder.extractSourceForgeProjectName() for an
approach.

Tags: lp-bugs
Gavin Panella (allenap)
Changed in malone:
assignee: nobody → allenap
importance: Undecided → High
milestone: none → 2.2.3
status: New → In Progress
Revision history for this message
Björn Tillenius (bjornt) wrote : Bug fixed by a commit

Fixed in devel r7882.

Changed in malone:
status: In Progress → Fix Committed
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.