zsnes sound works intermittently on multi-core systems
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
zsnes (Ubuntu) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Binary package hint: zsnes
There is a bug in the threading code of zsnes which causes sound to work intermittently on multi-core systems which use libao for sound output. For me sound worked about half the time. I've attached a debdiff which fixes this problem. In the zsnes forums, this problem was first mentioned here:
http://
later, zsnes unofficially released 1.51b which fixed this threading issue, as well as fixed build issues with gcc 4.3+.
http://
The attached debdiff brings the code up to match what's in the 1.51b package. Alternatively, we could rebuild the package based directly on the 1.51b original package, but that would mean diverging more from debian's package.
Changed in zsnes: | |
assignee: | nobody → quadrispro |
status: | Confirmed → In Progress |
The changes in this debdiff are as follows:
* Support building with gcc 4.3+. This was previously handled by a dpatch, but this update removes that dpatch. Now this matches how it is done in upstream version 1.51, which is strangely different from the 1.51 orig.tar.gz currently in the zsnes source package.
* Fixes a sound threading bug which breaks sound on multi-core systems.
Since sound being broken on multi-core systems seems like a significant bug, I'm nominating this patch for a feature freeze exception. I have built and tested this package and it works as expected.
Since 1.51b was an unofficial release, there is no upstream changelog for the new version. in addition, there appears to be no changelog between the 1.51 released in the ubuntu source package vs the 1.51 currently available for download on zsnes website.
This seems to be more of a bug fix patch than a feature change, but I'm subscribing motu-release for advice.