SFTP server should give human-friendly errors for name restrictions
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Andrew Bennetts |
Bug Description
https:/
We want to return sensible errors to the user when they hit one of these restrictions. Ideally, the user experience would look something like:
% bzr push sftp://
bzr: error creating directory cool-features. Server said:
branches must be inside a person or team directory
% bzr push sftp://
bzr: error creating directory ~mbp/cool-features. Server said:
branches must be inside a valid product name, or "+junk"
% bzr push sftp://
bzr: error creating directory ~linux-
you are not a member of the "linux-kernel" team
Currently, the SFTP server just sends generic permission denied errors. We need to determine if we can send more useful error messages via SFTP, and then make sure bzr reports them.
Changed in launchpad: | |
status: | Unconfirmed → Confirmed |
Changed in launchpad: | |
assignee: | nobody → spiv |
Changed in launchpad-bazaar: | |
status: | Confirmed → Fix Committed |
From skimming the relevant code in the server, and in bzr and paramiko, this looks like it's close to working (if it doesn't already). I think it just needs a newer Twisted in the SFTP server.
We should write some tests that this works with the bzr client talking to our SFTP server.