Last.fm connection failure notification assumes actions

[David Barth]

When a connection to Last.fm fails, a notification is sent with unconditional “Account Settings” and “Join Last.fm” actions. Since the connection failure is also already presented with buttons for these actions as a banner inside the window, the actions in the notification itself should be made conditional on whether the notification server accepts actions.

(This report previously also covered the new-track notification, now covered by bug 327640.)

[Andrew Conkling (andrewski)]

Sounds like two issues? The second issue is covered by bug 327640, already with a patch that was committed upstream.

On the first issue, can you describe the difference between what is presented now and what "an error alert box" would be?

[Andrew Conkling (andrewski)]

On Fri, Feb 13, 2009 at 09:52, Jorge O. Castro <email address hidden> wrote:

> ** Bug watch added: GNOME Bug Tracker #571177
> http://bugzilla.gnome.org/show_bug.cgi?id=571177

If this is related to that bug upstream, then this should be a duplicate of
bug 327640. Awaiting David's response to my comment above to see if there's
anything else that should be covered by this bug instead.

[David Barth (dbarth)]

The second issue is indeed a duplicate of bug 327640.

But the first issue is still pending resolution AFAIK. This is an enhancement request related to the changes introduced by our new notification system. The new notification system will not support actions in notification bubbles, and will temporarily convert them into a gray dialog box for compatibility reasons with applications that don't check the server capabilities.

The correct resolution would be to consider that if the Last.fm connection fails, it is a situation serious enough to have a non-modal, not focused by default, dialog box popping up to warn the user about that. This should be implemented directly in the plugin, for the application to have a better control of the dialog.

[Ken VanDine (ken-vandine)]

As far as I can tell, these notifications are handled internally in banshee. So they don't trigger external notifications. Shouldn't be an issue at all. Please re-open if this isn't correct.

[Eitan Isaacson (eeejay)]

Following Ken's example, and invalidating this.