Manually retried builds scored to 0 priority and stay there

[Scott Kitterman]

Manually retried builds are scored behind regular uploads of any kind. They should be scored as they would for any upload of their catagory.

I have seen people do sourceful upload to fix a single architecture in order to get around this problem. This causes other buildd's to be unnecessarily burdened. Alternatively, people have to seek out a buildd admin to get builds manually rescored and this diverts them from other important work.

If there is any bias applied to a retry, it ought to come at a higher priority rather than lower since a developer has made a determination that they want that specific build done. I don't think there should be a bias, but if there is one, the current one goes in the wrong direction.

[Celso Providelo (cprov)]

Scott,

The problem with allowing retrying with the original score it that we have no way to identify if the build will succeed or fail again.

Since all uploaders are allowed to retry their failures, we can't guarantee that everyone will be as conscious as you are and will not retry obvious FTBFS several times consuming build-power for nothing.

Scheduling retried build for later gives more fairness to the system granting building slots for sources that were not tried before.

Surely for the case you pointed where you do know that the failure causes are gone and retrying the source immediately is beneficial, poking a buildd-admin isn't necessarily disrupting.

[Colin Watson (cjwatson)]

I tend to agree with Celso, but think that it ought to be made clearer to retriers what's going on, and what they can do about it. Something like "by default, this build will be retried after other pending builds; please contact a build daemon administrator if you need special treatment"?

[Scott Kitterman (kitterman)]

My experience is that it is. There are not many buildd admins and there is
no structured way to reach them. If developers are abusing retries, then
we have a training problem. We should fix that.

[Julian Edwards (julian-edwards)]

I am going to implement Colin's suggestion.

[Scott Kitterman (kitterman)]

I've come to agree that the same priority as the initial upload isn't necessarily the best idea. OTOH, I have seen people do new uploads to get a higher priority.

If there was some spread among the retries so Main would go first, I think that would address some of my concerns without being overly disruptive to the current syste.

[Julian Edwards (julian-edwards)]

RF 8006
As a bonus, I added a "cancel" link and the page now also redirects back to the build page after the retry.