initctl: status should return a non-zero exit code if job not found

Bug #328323 reported by gcooper
0
Affects Status Importance Assigned to Milestone
upstart
Fix Released
Medium
Scott James Remnant (Canonical)

Bug Description

[comet-k5-12:~]$ cat /etc/init/jobs.d/foo
foo
[comet-k5-12:~]$ status
console_5foutput not running
eiclid not running
novainit not running
slproc not running
messagebus running
river_5fserver running
autostartnova not running
ha_5fmgr not running
psd not running
rc4 not running
smand not running
control_2dalt_2ddelete not running
rc5 not running
urhd not running
btrace_5frotate not running
rc6 not running
hmand not running
ioucon not running
rc0 not running
rc1 not running
rcS not running
novastart not running
rc_2ddefault not running
rc2 not running
qauthJob not running
rc3 not running
novastop not running
sulogin not running
novastatus not running
author_5fpos1 running
dnsprovider not running
iosd not running
agetty running
disable_5finterfaces not running
eicored not running
ffm not running
iifd not running
plogd not running
rcS_2dsulogin not running
[comet-k5-12:~]$ grep foo /var/log/messages
Feb 11 17:03:00 comet-k5-12 <1234371780,821143>init: /etc/init/jobs.d/foo:1: Unknown stanza

Changed in upstart:
importance: Undecided → Medium
milestone: none → 0.5-later
status: New → Triaged
Revision history for this message
gcooper (yanegomi-deactivatedaccount) wrote :

Please close this item; I was in a rush and probably got confused this with another testcase I was working on.

Thanks!
-Garrett

Revision history for this message
gcooper (yanegomi-deactivatedaccount) wrote :

I'm reopening this issue because it does in fact exist:

[10:~]$ initctl status foo
[10:~]$ echo $?
0
[10:~]$ initctl status | grep foo
[10:~]$

Sorry for the additional noise Scott ><.

Changed in upstart:
milestone: 0.5-later → none
summary: - initctl status should return a non-zero exit code if job not found
+ initctl: status should return a non-zero exit code if job not found
Changed in upstart:
status: Triaged → Fix Committed
Changed in upstart:
milestone: none → 0.6.0
Revision history for this message
Scott James Remnant (Canonical) (canonical-scott) wrote :
Download full text (6.7 KiB)

This has been fixed in Upstart 0.6.0.

0.6.0 2009-07-09 "How appropriate, you fight like a cow"

 * The licence for Upstart has been changed back to version 2 of the
   GNU GPL.

 * D-Bus 1.2.15 is now required, this is the current GIT HEAD
   pending a 1.2.16 release.

 * Configuration paths have changed. Global configuration now
   resides in "/etc/init.conf" while jobs are now configured in
   "/etc/init"

 * Job configuration filenames must now end in ".conf"

 * Default configuration files are now supplied in the "conf"
   sub-directory of the source, and installed into "/etc/init".

   These match the Debian/Ubuntu sysvinit configuration so may
   require some tweaking for other distributions, but provide an
   excellent base.

   The old example-jobs tarballs are deprecated.

 * The D-Bus interface remains unstable, to reflect this the current
   interface name has changed to "com.ubuntu.Upstart0_6" and the
   name of the job and instance interfaces have changed to match.

 * The "EmitEvent" D-Bus method gains a wait argument, when given
   as TRUE (the recommended setting) the method call will be blocked
   until all effects of the event have finished. When FALSE the
   method call will return once the event has been queued.

 * The "Start", "Stop" and "Restart" D-Bus methods of jobs and
   instances gain a similar wait argument.

 * The Upstart D-Bus object now has "version" and "log_priority"
   properties. The former is to obtain the version of the init daemon,
   the latter allows you to obtain and change the logging priority.

 * Job D-Bus objects now have "name", "description", "author" and
   "version" properties to obtain the job name and the contents of
   the equivalent job file fields for the others.

 * Instance D-Bus objects now have "name", "goal", "state" and
   "processes" properties to obtain the instance name, goal, state
   and list of running processes and their pids respectively.

 * The default D-Bus security policy now permits use of the "Get"
   methods by all users, including obtaining values of properties.

 * initctl has been rewritten with functionality more along the
   lines of Upstart 0.3.x than before; since many distributions are
   still shipping 0.3.x the summary of changes for the tool reflects
   both changes from 0.3.x and 0.5.x

 * The global "-p"/"--pid" argument has been dropped, since
   communication is over D-Bus. New "--system" and "--dest" arguments
   have been added to force communication over the system bus, and
   specify the destination, instead of using the private socket (this
   is the default when run as non-root to permit "list" and "status"
   to work for ordinary users).

 * The "-i"/"--id" and "--show-ids" options to commands have been
   dropped since jobs no longer have ids.

 * Since instances may now have names, these will be displayed in
   brackets after the job name when one is present. The output of
   the goal and state are now expressed as "start/running" instead
   of "(start) running" to disambiguate.

 * initctl "start" and "stop" now only output the final state of
   the job, not inte...

Read more...

Changed in upstart:
assignee: nobody → Scott James Remnant (scott)
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.