UserWarning "ProgressTask... is not the top progress task" from unshelve, please

[Dan Watkins]

$ bzr unshelve
Unshelving changes with id "1".
/home/dwa/devel/bzr.dev/bzrlib/ui/text.py:96: UserWarning: ProgressTask(0/3, msg='Merge phase') is not the top progress task ProgressTask(None/None, msg='')
  (task, self._task_stack[-1]))
/home/dwa/devel/bzr.dev/bzrlib/ui/text.py:96: UserWarning: ProgressTask(1/3, msg='Merge phase') is not the top progress task ProgressTask(None/None, msg='')
  (task, self._task_stack[-1]))
 M overview/overview.en.tex
/home/dwa/devel/bzr.dev/bzrlib/ui/text.py:96: UserWarning: ProgressTask(2/3, msg='Merge phase') is not the top progress task ProgressTask(None/None, msg='')
  (task, self._task_stack[-1]))
All changes applied successfully.

(What is this fabric oval? What does it mean?)

[John A Meinel (jameinel)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daniel Watkins wrote:
> Public bug reported:
>
> $ bzr unshelve
> Unshelving changes with id "1".
> /home/dwa/devel/bzr.dev/bzrlib/ui/text.py:96: UserWarning: ProgressTask(0/3, msg='Merge phase') is not the top progress task ProgressTask(None/None, msg='')
> (task, self._task_stack[-1]))
> /home/dwa/devel/bzr.dev/bzrlib/ui/text.py:96: UserWarning: ProgressTask(1/3, msg='Merge phase') is not the top progress task ProgressTask(None/None, msg='')
> (task, self._task_stack[-1]))
> M overview/overview.en.tex
> /home/dwa/devel/bzr.dev/bzrlib/ui/text.py:96: UserWarning: ProgressTask(2/3, msg='Merge phase') is not the top progress task ProgressTask(None/None, msg='')
> (task, self._task_stack[-1]))
> All changes applied successfully.
>
>
> (What is this fabric oval? What does it mean?)
>

This has to do with the new progress bars that Martin worked on. You
generally get this message when someone does:

pb = ui.ui_factory.nested_progress_bar()
child_pb = ui.ui_factory.nested_progress_bar()

pb.update()

child_pb.finished()
pb.finished()

Note that they create an inner "progress" but then update the outer one.

I know I tracked down one place this was happening, which has thus been
fixed in bzr.dev. Is this still happening elsewhere? Or do you just need
to update your copy of bzr.dev?

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmTDRgACgkQJdeBCYSNAAPL4QCfYg55GSCnY2NazQSOCkqrNh3w
G78AoJQWTi7pqsGi+fMu9c5TMw6+pEC4
=xOm7
-----END PGP SIGNATURE-----

[Dan Watkins (oddbloke)]

On Wed, 2009-02-11 at 17:38 +0000, John A Meinel wrote:
> Note that they create an inner "progress" but then update the outer one.
>
> I know I tracked down one place this was happening, which has thus been
> fixed in bzr.dev. Is this still happening elsewhere? Or do you just need
> to update your copy of bzr.dev?

I can reproduce on r4000 (which I just pulled).